Bug 221000 - [macOS] Remove CFPBS access in the WebContent process
Summary: [macOS] Remove CFPBS access in the WebContent process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-26 11:40 PST by Per Arne Vollan
Modified: 2021-02-03 14:51 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2021-01-26 11:42 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2021-01-27 09:58 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (1.40 KB, patch)
2021-01-27 10:16 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-01-26 11:40:39 PST 
Remove CFPBS access in the WebContent process on macOS, since there are no reports of this being used.
Comment 1 Per Arne Vollan 2021-01-26 11:41:00 PST 
<rdar://problem/70501475>
Comment 2 Per Arne Vollan 2021-01-26 11:42:56 PST 
Created attachment 418453 [details]
Patch
Comment 3 Brent Fulgham 2021-01-27 09:39:48 PST 
Comment on attachment 418453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418453&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-1238
> -    (ipc-posix-name-regex #"^CFPBS:")) ; <rdar://problem/13757475>

To be safe, should we just move the version check so we leave this on for older OS's? We don't have telemetry for old systems.
Comment 4 Per Arne Vollan 2021-01-27 09:58:52 PST 
Created attachment 418556 [details]
Patch
Comment 5 Brent Fulgham 2021-01-27 09:59:43 PST 
Comment on attachment 418556 [details]
Patch

Excellent! r=me
Comment 6 Per Arne Vollan 2021-01-27 10:06:57 PST 
Comment on attachment 418556 [details]
Patch

Thanks for reviewing!
Comment 7 EWS 2021-01-27 10:07:41 PST 
Tools/Scripts/svn-apply failed to apply attachment 418556 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Per Arne Vollan 2021-01-27 10:16:25 PST 
Created attachment 418557 [details]
Patch
Comment 9 EWS 2021-01-27 10:45:51 PST 
Committed r271966: <https://trac.webkit.org/changeset/271966>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418557 [details].