Bug 220993 – REGRESSION(r270637) Filtering does not work in Styles sidebar panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Razvan Caliman]

Regressed by https://bugs.webkit.org/show_bug.cgi?id=218964

Steps to reproduce:

- Go to https://webkit.org
- Open WebInspector and select an element
- Switch to Styles sidebar panel
- Type a CSS property value into the Filter input at the bottom of the styles

Expected:
- The styles list is filtered by the term

Actual:
- No change in the styles list

[Radar WebKit Bug Importer]

<rdar://problem/73623818>

[Nikita Vasilyev]

[Error] TypeError: super.filterDidChange is not a function. (In 'super.filterDidChange(filterBar)', 'super.filterDidChange' is undefined)
	filterDidChange (SpreadsheetRulesStyleDetailsPanel.js:323)
	_filterDidChange (GeneralStyleDetailsSidebarPanel.js:431)
	dispatch (Object.js:130)
	dispatchEventToListeners (Object.js:138)
	_handleFilterChanged (FilterBar.js:198)
	_handleFilterChanged

[Razvan Caliman]

Created attachment 418448 [details]
Patch

[Devin Rousso]

Comment on attachment 418448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review

r=me with a recommended alternative

> Source/WebInspectorUI/ChangeLog:9
> +        Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel.

I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`.  `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it.

[Razvan Caliman]

Created attachment 418454 [details]
Patch

[Razvan Caliman]

Comment on attachment 418448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review

>> Source/WebInspectorUI/ChangeLog:9
>> +        Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel.
> 
> I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`.  `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it.

Sounds good. Done!

[Devin Rousso]

Comment on attachment 418454 [details]
Patch

r=me

[Blaze Burg]

Setting cq+

[EWS]

Committed r271927: <https://trac.webkit.org/changeset/271927>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418454 [details].