[BigSur] Enable NSURLSession WebSocket code path in WebKitTestRunner
Created attachment 418407 [details]
Comment on attachment 418407 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=418407&action=review
> + // FIXME: reenable below ASSERT once rdar://problem/72383646 is fixed.
Better grammar would be:
// FIXME: We can re-enable ASSERT below once NSURLSession bug rdar://problem/72383646 is fixed.
Ideally the comment makes it clear or at least implies that it’s not urgent to re-enable the assertion and there’s no detectable symptom of the bug.
Created attachment 418513 [details]
Patch for landing
I can see flakiness in some tests when running them several times.
I believe this is due to rdar://problem/73613227.
Let's see whether these potential flakinesses will disturb the bots.
Committed r271940: <https://trac.webkit.org/changeset/271940>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 418513 [details].
Re-opened since this is blocked by bug 221040
Some additional test failures found in the bot:
Created attachment 424773 [details]
Rebased patch and bumped support to after BigSur and iOS 15.
This removes the need to update test expectations.
Committed r275415: <https://commits.webkit.org/r275415>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 424773 [details].