Bug 220973 - [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner
Summary: [MacOS] Enable NSURLSession WebSocket code path in WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 221040
Blocks:
  Show dependency tree / graph
 
Reported: 2021-01-26 05:41 PST by youenn fablet
Modified: 2021-04-02 03:44 PDT (History)
8 users (show)

See Also:

Attachments
Patch (58.92 KB, patch)
2021-01-26 06:04 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (59.06 KB, patch)
2021-01-27 00:57 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Rebasing (4.87 KB, patch)
2021-03-31 08:46 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2021-01-26 05:41:46 PST 
[BigSur] Enable NSURLSession WebSocket code path in WebKitTestRunner
Comment 1 youenn fablet 2021-01-26 06:04:01 PST 
Created attachment 418407 [details]
Patch
Comment 2 Darin Adler 2021-01-26 09:43:29 PST 
Comment on attachment 418407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418407&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1038
> +        // FIXME: reenable below ASSERT once rdar://problem/72383646 is fixed.

Better grammar would be:

    // FIXME: We can re-enable ASSERT below once NSURLSession bug rdar://problem/72383646 is fixed.

Ideally the comment makes it clear or at least implies that it’s not urgent to re-enable the assertion and there’s no detectable symptom of the bug.
Comment 3 youenn fablet 2021-01-27 00:57:05 PST 
Created attachment 418513 [details]
Patch for landing
Comment 4 youenn fablet 2021-01-27 02:40:13 PST 
I can see flakiness in some tests when running them several times.
I believe this is due to rdar://problem/73613227.
Let's see whether these potential flakinesses will disturb the bots.
Comment 5 EWS 2021-01-27 02:57:27 PST 
Committed r271940: <https://trac.webkit.org/changeset/271940>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418513 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-27 02:58:14 PST 
<rdar://problem/73655870>
Comment 7 WebKit Commit Bot 2021-01-27 06:18:24 PST 
Re-opened since this is blocked by bug 221040
Comment 8 youenn fablet 2021-01-27 06:18:49 PST 
Some additional test failures found in the bot:
https://build.webkit.org/results/Apple-BigSur-Release-WK2-Tests/r271940%20(1203)/results.html
Comment 9 youenn fablet 2021-03-31 08:46:06 PDT 
Created attachment 424773 [details]
Rebasing
Comment 10 youenn fablet 2021-03-31 08:46:43 PDT 
Rebased patch and bumped support to after BigSur and iOS 15.
This removes the need to update test expectations.
Comment 11 EWS 2021-04-02 03:44:24 PDT 
Committed r275415: <https://commits.webkit.org/r275415>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424773 [details].