Bug 220963 - [LFC][IFC] ASSERT(constraints.left->x <= constraints.right->x) when left and right floats run out of space
Summary: [LFC][IFC] ASSERT(constraints.left->x <= constraints.right->x) when left and ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-25 20:47 PST by Simon Fraser (smfr)
Modified: 2021-02-07 18:11 PST (History)
4 users (show)

See Also:


Attachments
Testcase (2.78 KB, text/html)
2021-01-25 20:47 PST, Simon Fraser (smfr)
no flags Details
Patch (4.35 KB, patch)
2021-02-07 11:10 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2021-02-07 13:14 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (4.35 KB, patch)
2021-02-07 17:03 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-01-25 20:47:47 PST
Created attachment 418368 [details]
Testcase

Attached testcase hits an assertion when the window width is not wide enough for the floats to be side-by-side.
Comment 1 Radar WebKit Bug Importer 2021-02-01 20:48:31 PST
<rdar://problem/73861675>
Comment 2 zalan 2021-02-07 11:10:53 PST
Created attachment 419542 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-02-07 12:43:48 PST
Comment on attachment 419542 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419542&action=review

> Source/WebCore/ChangeLog:20
> +        and as we try to find space for the inline content, we may end up with a vertical rage (candidate line position + line height)

vertical rage
Comment 4 zalan 2021-02-07 13:10:35 PST
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 419542 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419542&action=review
> 
> > Source/WebCore/ChangeLog:20
> > +        and as we try to find space for the inline content, we may end up with a vertical rage (candidate line position + line height)
> 
> vertical rage
floats can actually cause vertical rage.
Comment 5 zalan 2021-02-07 13:14:50 PST
Created attachment 419545 [details]
Patch
Comment 6 EWS 2021-02-07 13:16:19 PST
ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
Comment 7 zalan 2021-02-07 17:03:03 PST
Created attachment 419550 [details]
Patch
Comment 8 EWS 2021-02-07 18:11:48 PST
Committed r272478: <https://commits.webkit.org/r272478>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419550 [details].