Created attachment 418360 [details]
Created attachment 418361 [details]
Comment on attachment 418361 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=418361&action=review
> + if (!RealtimeMediaSourceCenter::shouldInterruptAudioOnPageVisibilityChange())
This seems like it may need to be in at least a #if ENABLE(MEDIA_STREAM) since RealtimeMediaSourceCenter.h uses one around the whole body.
Created attachment 418376 [details]
Comment on attachment 418376 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=418376&action=review
> + m_suspended = true;
Do we really need that change?
It moves away from being able to apply user gesture constraint to this API, which seems desirable given this asks for microphone and can prompt the user.
Created attachment 418432 [details]
Created attachment 418479 [details]
Created attachment 418502 [details]
Committed r271935: <https://trac.webkit.org/changeset/271935>
All reviewed patches have been landed. Closing bug and clearing flags on attachment 418502 [details].