Bug 220959 - Add stub in ContentExtensionsBackend for HTTPS upgrade
Summary: Add stub in ContentExtensionsBackend for HTTPS upgrade
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-25 17:02 PST by Alex Christensen
Modified: 2021-02-26 09:21 PST (History)
3 users (show)

See Also:

Attachments
Patch (7.00 KB, patch)
2021-01-25 17:05 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-01-25 17:02:56 PST 
Add stub in ContentExtensionsBackend for HTTPS upgrade
Comment 1 Alex Christensen 2021-01-25 17:05:37 PST 
Created attachment 418358 [details]
Patch
Comment 2 Alex Christensen 2021-01-26 11:32:11 PST 
Comment on attachment 418358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review

> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58
> +#import <WebKitAdditions/ContentRuleListAdditions.mm>

Implemented in rdar://problem/73625317
Comment 3 Geoffrey Garen 2021-01-26 16:10:23 PST 
Comment on attachment 418358 [details]
Patch

r=me
Comment 4 Radar WebKit Bug Importer 2021-02-01 17:03:21 PST 
<rdar://problem/73854237>
Comment 5 EWS 2021-02-02 19:08:33 PST 
Committed r272293: <https://trac.webkit.org/changeset/272293>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418358 [details].
Comment 6 Simon Fraser (smfr) 2021-02-25 08:53:46 PST 
Comment on attachment 418358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review

>> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58
>> +#import <WebKitAdditions/ContentRuleListAdditions.mm>
> 
> Implemented in rdar://problem/73625317

How is it that we pull a .mm file into a .cpp file?
Comment 7 Alex Christensen 2021-02-26 09:21:45 PST 
Comment on attachment 418358 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review

>>> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58
>>> +#import <WebKitAdditions/ContentRuleListAdditions.mm>
>> 
>> Implemented in rdar://problem/73625317
> 
> How is it that we pull a .mm file into a .cpp file?

That's not great.  The c preprocessor can pull anything in.  This mm file happens to not have any objc so it works.  We should rename it.