RESOLVED FIXED 220959
Add stub in ContentExtensionsBackend for HTTPS upgrade 
https://bugs.webkit.org/show_bug.cgi?id=220959
Summary Add stub in ContentExtensionsBackend for HTTPS upgrade
Alex Christensen
Reported 2021-01-25 17:02:56 PST
Add stub in ContentExtensionsBackend for HTTPS upgrade
Attachments
Patch (7.00 KB, patch)
2021-01-25 17:05 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2021-01-25 17:05:37 PST
Created attachment 418358 [details] Patch
Alex Christensen
Comment 2 2021-01-26 11:32:11 PST
Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review > Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 > +#import <WebKitAdditions/ContentRuleListAdditions.mm> Implemented in rdar://problem/73625317
Geoffrey Garen
Comment 3 2021-01-26 16:10:23 PST
Comment on attachment 418358 [details] Patch r=me
Radar WebKit Bug Importer
Comment 4 2021-02-01 17:03:21 PST
<rdar://problem/73854237>
EWS
Comment 5 2021-02-02 19:08:33 PST
Committed r272293: <https://trac.webkit.org/changeset/272293> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418358 [details].
Simon Fraser (smfr)
Comment 6 2021-02-25 08:53:46 PST
Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review >> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 >> +#import <WebKitAdditions/ContentRuleListAdditions.mm> > > Implemented in rdar://problem/73625317 How is it that we pull a .mm file into a .cpp file?
Alex Christensen
Comment 7 2021-02-26 09:21:45 PST
Comment on attachment 418358 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418358&action=review >>> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:58 >>> +#import <WebKitAdditions/ContentRuleListAdditions.mm> >> >> Implemented in rdar://problem/73625317 > > How is it that we pull a .mm file into a .cpp file? That's not great. The c preprocessor can pull anything in. This mm file happens to not have any objc so it works. We should rename it.
Note You need to log in before you can comment on or make changes to this bug.