RESOLVED FIXED 220956
Crash when remote inspecting in debug builds 
https://bugs.webkit.org/show_bug.cgi?id=220956
Summary Crash when remote inspecting in debug builds
Simon Fraser (smfr)
Reported 2021-01-25 15:28:22 PST
Crash when remote inspecting in debug builds
Attachments
Patch (9.67 KB, patch)
2021-01-25 15:30 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (9.72 KB, patch)
2021-01-25 16:14 PST, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2021-01-25 15:30:25 PST
Created attachment 418347 [details] Patch
Devin Rousso
Comment 2 2021-01-25 15:40:08 PST
Comment on attachment 418347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418347&action=review > Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:215 > + dispatchAsyncOnTarget([this, message = [[message copy] autorelease], strongThis = makeRef(*this)]() { I believe that `message` isn't ever used after calling `sendMessageToTarget`. Can we avoid creating a copy?
Simon Fraser (smfr)
Comment 3 2021-01-25 16:14:15 PST
Created attachment 418355 [details] Patch
Devin Rousso
Comment 4 2021-01-25 16:24:38 PST
Comment on attachment 418355 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418355&action=review r=me, nice fix! > Source/JavaScriptCore/inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:207 > + if (targetIdentifier) Why was this added? `RemoteInspector::updateTargetListing` should be able to handle `0`.
EWS
Comment 5 2021-01-25 21:09:22 PST
Committed r271876: <https://trac.webkit.org/changeset/271876> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418355 [details].
Radar WebKit Bug Importer
Comment 6 2021-01-25 21:10:14 PST
<rdar://problem/73602775>
Blaze Burg
Comment 7 2021-01-25 22:17:18 PST
Comment on attachment 418355 [details] Patch Thanks for digging on this, Simon!
Joseph Pecoraro
Comment 8 2021-01-29 10:03:36 PST
Do we actually know why BlockPtr doesn't work well with ARC?
Simon Fraser (smfr)
Comment 9 2021-01-29 11:50:57 PST
It works fine with ARC, but not when the linker links an ARC-compiled function into a caller that is not complied with ARC.
Note You need to log in before you can comment on or make changes to this bug.