Remove MediaSourcePrivateClient::monitorSourceBuffers()
Created attachment 418332 [details] Patch
Created attachment 418337 [details] Patch
Created attachment 418339 [details] Patch
<rdar://problem/73844547>
Comment on attachment 418339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418339&action=review > Source/WebCore/ChangeLog:10 > + related to seeking. Why keeping it for GStreamer, I do not see GStreamer code related to it?
Comment on attachment 418339 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418339&action=review >> Source/WebCore/ChangeLog:10 >> + related to seeking. > > Why keeping it for GStreamer, I do not see GStreamer code related to it? https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp#L329
I built this on GTK and didn't see any new failures in GTK Debug LayoutTests. I don't see a problem myself.
(In reply to Philippe Normand from comment #6) > Comment on attachment 418339 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418339&action=review > > >> Source/WebCore/ChangeLog:10 > >> + related to seeking. > > > > Why keeping it for GStreamer, I do not see GStreamer code related to it? > > https://github.com/WebKit/WebKit/blob/main/Source/WebCore/platform/graphics/ > gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp#L329 Given monitorSourceBuffers implementation does not seem to do anything, can MediaPlayerPrivateGStreamerMSE.cpp be updated to remove the call to monitorSourceBuffers?
I guess we're looking at different code-bases then :) MediaSource::monitorSourceBuffers() does quite a few things, including calling completeSeek().
Let's only remove this function for apple's ports.
Committed r272696: <https://commits.webkit.org/r272696> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418339 [details].