RESOLVED FIXED 220941
[Curl] Enable FTP protocol only when ENABLE_FTPDIR is on 
https://bugs.webkit.org/show_bug.cgi?id=220941
Summary [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on
Don Olmstead
Reported 2021-01-25 12:26:16 PST
...
Attachments
Patch (2.85 KB, patch)
2021-01-25 12:33 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2021-01-25 12:33:49 PST
Created attachment 418322 [details] Patch
Fujii Hironori
Comment 2 2021-01-26 12:41:07 PST
Comment on attachment 418322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/cmake/OptionsWin.cmake:90 > + WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF) Nice. However, this is a breaking change. But, I think no WinCairo users are affected.
Fujii Hironori
Comment 3 2021-01-26 12:43:39 PST
Comment on attachment 418322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/WebCore/platform/network/curl/CurlContext.cpp:534 > +#if ENABLE(FTPDIR) All upstream curl ports disable FTDIR now. You can remove this unused code if you want.
Radar WebKit Bug Importer
Comment 4 2021-02-01 12:27:14 PST
<rdar://problem/73840873>
EWS
Comment 5 2021-02-01 13:19:02 PST
Committed r272171: <https://trac.webkit.org/changeset/272171> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418322 [details].
Note You need to log in before you can comment on or make changes to this bug.