Bug 220939 – Rename MediaElementSession::playbackPermitted() to MediaElementSession::playbackStateChangePermitted()

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

MediaElementSession::playbackPermitted() is used in many places to check whether a playback state change is allowed or not. We had better add a parameter to indicate the state change request. Otherwise, it may return false when it is expected to return true.

[Radar WebKit Bug Importer]

<rdar://problem/73839280>

[Peng Liu]

Created attachment 424602 [details]
Patch

[Eric Carlson]

Comment on attachment 424602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424602&action=review

> Source/WebCore/html/MediaElementSession.cpp:286
>          ALWAYS_LOG(LOGIDENTIFIER, "Returning FALSE because element is suspended");

Now that we always pass the new state, it would be nice to include that in the logging so we know what state change was allowed/denied.

[Peng Liu]

Comment on attachment 424602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424602&action=review

>> Source/WebCore/html/MediaElementSession.cpp:286
>>          ALWAYS_LOG(LOGIDENTIFIER, "Returning FALSE because element is suspended");
> 
> Now that we always pass the new state, it would be nice to include that in the logging so we know what state change was allowed/denied.

Good idea! Will add that.

[Peng Liu]

Created attachment 424656 [details]
Patch for landing

[EWS]

Committed r275225: <https://commits.webkit.org/r275225>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 424656 [details].