The glib API test runner fails to report crashes in the test harness (e.g. the `beforeAll()` family of functions). This hid the issues setting up WebKitTestServer, related to bug220366 and bug220922 (reverted the original Soup commits). Patch almost ready.
Created attachment 418366 [details] Patch
Comment on attachment 418366 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418366&action=review Good catch, thanks! > Tools/glib/glib_test_runner.py:272 > + if (not self._results) and p.returncode != 0: Do we need the parentheses here? > Tools/glib/glib_test_runner.py:278 > + elif p.returncode != 0 and not need_restart: # Try to read errors from afterAll Don't use else after a return
Created attachment 418430 [details] Patch for landing.
Committed r271902: <https://trac.webkit.org/changeset/271902> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418430 [details].
<rdar://problem/73630623>