.
<rdar://problem/71911346>
Created attachment 418308 [details] Patch
Comment on attachment 418308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418308&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:399 > + uint64_t _activeTextInteractionCount; That's a lot of active text interactions! > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5351 > + --_activeTextInteractionCount; How sure are you this will never underflow? Maybe an assertion at a minimum?
Comment on attachment 418308 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418308&action=review >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:399 >> + uint64_t _activeTextInteractionCount; > > That's a lot of active text interactions! /me attempts to see how many interactions he could have at the same time Aside: I guess I could make it an `NSInteger` instead to match other member variables 🤔 >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:5351 >> + --_activeTextInteractionCount; > > How sure are you this will never underflow? Maybe an assertion at a minimum? Good idea.
Created attachment 418316 [details] Patch
Committed r271868: <https://trac.webkit.org/changeset/271868> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418316 [details].