Bug 220931 - [macOS] Create extension to Metal compiler service based on GPUP flags
Summary: [macOS] Create extension to Metal compiler service based on GPUP flags
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-25 09:30 PST by Per Arne Vollan
Modified: 2021-01-25 14:39 PST (History)
2 users (show)

See Also:

Attachments
Patch (6.41 KB, patch)
2021-01-25 09:32 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (7.27 KB, patch)
2021-01-25 10:26 PST, Per Arne Vollan 		bfulgham: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (8.53 KB, patch)
2021-01-25 12:29 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.49 KB, patch)
2021-01-25 12:38 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (8.52 KB, patch)
2021-01-25 13:32 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-01-25 09:30:51 PST 
Depending on which GPUP settings are enabled, an extension to the Metal compiler service should be created.
Comment 1 Per Arne Vollan 2021-01-25 09:32:36 PST 
Created attachment 418300 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-01-25 09:33:31 PST 
<rdar://problem/73574476>
Comment 3 Per Arne Vollan 2021-01-25 10:26:25 PST 
Created attachment 418305 [details]
Patch
Comment 4 Brent Fulgham 2021-01-25 11:46:33 PST 
Comment on attachment 418305 [details]
Patch

r=me. Note that MTLCompiler will be needed for DOM rendering, so there will likely be few cases where this is not needed, but good to be able to turn it off when experimenting with DOM rendering.
Comment 5 Per Arne Vollan 2021-01-25 12:29:00 PST 
Created attachment 418321 [details]
Patch
Comment 6 Per Arne Vollan 2021-01-25 12:38:40 PST 
Created attachment 418323 [details]
Patch
Comment 7 Per Arne Vollan 2021-01-25 13:32:00 PST 
Created attachment 418329 [details]
Patch
Comment 8 Per Arne Vollan 2021-01-25 14:07:35 PST 
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 418305 [details]
> Patch
> 
> r=me. Note that MTLCompiler will be needed for DOM rendering, so there will
> likely be few cases where this is not needed, but good to be able to turn it
> off when experimenting with DOM rendering.

Sounds good, thanks for reviewing!
Comment 9 EWS 2021-01-25 14:39:42 PST 
Committed r271860: <https://trac.webkit.org/changeset/271860>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418329 [details].