Bug 220929 - [iOS] Obscured elements should not be focusable using the accessory bar
Summary: [iOS] Obscured elements should not be focusable using the accessory bar
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-25 09:25 PST by Aditya Keerthi
Modified: 2021-01-25 14:52 PST (History)
10 users (show)

See Also:

Attachments
Patch (8.87 KB, patch)
2021-01-25 09:45 PST, Aditya Keerthi 		thorton: review+
Details | Formatted Diff | Diff
Patch for landing (8.83 KB, patch)
2021-01-25 12:23 PST, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-01-25 09:25:02 PST 
...
Comment 1 Aditya Keerthi 2021-01-25 09:25:17 PST 
<rdar://problem/73239409>
Comment 2 Aditya Keerthi 2021-01-25 09:45:55 PST 
Created attachment 418301 [details]
Patch
Comment 3 Tim Horton 2021-01-25 12:10:00 PST 
Comment on attachment 418301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418301&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556
> +static inline bool isObscuredElement(Element& element)

Why `IgnoreClipping`? Wouldn't you want to take clipping into account to know if you can see the thing?
Comment 4 Aditya Keerthi 2021-01-25 12:23:38 PST 
Created attachment 418320 [details]
Patch for landing
Comment 5 Aditya Keerthi 2021-01-25 12:25:36 PST 
(In reply to Tim Horton from comment #3)
> Comment on attachment 418301 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418301&action=review
> 
> > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2556
> > +static inline bool isObscuredElement(Element& element)
> 
> Why `IgnoreClipping`? Wouldn't you want to take clipping into account to
> know if you can see the thing?

Right – I've removed `IgnoreClipping`.
Comment 6 EWS 2021-01-25 14:52:02 PST 
Committed r271861: <https://trac.webkit.org/changeset/271861>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418320 [details].