Bug 220927 - [macOS] Restrict access to dtracehelper
Summary: [macOS] Restrict access to dtracehelper
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-25 08:44 PST by Per Arne Vollan
Modified: 2022-09-17 17:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.42 KB, patch)
2021-01-25 08:50 PST, Per Arne Vollan 		bfulgham: review+
Details | Formatted Diff | Diff
Patch (2.40 KB, patch)
2021-01-25 12:55 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (2.20 KB, patch)
2021-01-25 13:10 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-01-25 08:44:39 PST 
Only allow access to dtracehelper for internal installs.
Comment 1 Per Arne Vollan 2021-01-25 08:47:39 PST 
<rdar://70350947>
Comment 2 Per Arne Vollan 2021-01-25 08:50:24 PST 
Created attachment 418297 [details]
Patch
Comment 3 Brent Fulgham 2021-01-25 11:35:04 PST 
Comment on attachment 418297 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418297&action=review

r=me

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89
>      (with telemetry-backtrace)

Should we remove this, given that telemetry-backtrace is a finite resource and we know this is needed for internal builds?
Comment 4 Per Arne Vollan 2021-01-25 12:55:03 PST 
Created attachment 418324 [details]
Patch
Comment 5 Per Arne Vollan 2021-01-25 12:55:37 PST 
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 418297 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418297&action=review
> 
> r=me
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89
> >      (with telemetry-backtrace)
> 
> Should we remove this, given that telemetry-backtrace is a finite resource
> and we know this is needed for internal builds?

Fixed, thanks for reviewing!
Comment 6 Per Arne Vollan 2021-01-25 13:10:28 PST 
Created attachment 418328 [details]
Patch
Comment 7 EWS 2021-01-25 14:09:58 PST 
Committed r271815: <https://trac.webkit.org/changeset/271815>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418328 [details].