Bug 220907 - Upstream to WPT Shadow DOM tests related to :focus pseudo-class
Summary: Upstream to WPT Shadow DOM tests related to :focus pseudo-class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-24 23:12 PST by Manuel Rego Casasnovas
Modified: 2021-01-27 05:09 PST (History)
5 users (show)

See Also:

Attachments
Patch (23.73 KB, patch)
2021-01-24 23:14 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (23.72 KB, patch)
2021-01-24 23:16 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (23.73 KB, patch)
2021-01-24 23:58 PST, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Patch (24.99 KB, patch)
2021-01-26 22:04 PST, Manuel Rego Casasnovas 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2021-01-24 23:12:35 PST 
These tests landed originally in r250788 (https://webkit.org/b/202432).
Comment 1 Manuel Rego Casasnovas 2021-01-24 23:14:06 PST 
Created attachment 418251 [details]
Patch
Comment 2 EWS Watchlist 2021-01-24 23:15:06 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Manuel Rego Casasnovas 2021-01-24 23:16:40 PST 
Created attachment 418252 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2021-01-24 23:58:17 PST 
Created attachment 418255 [details]
Patch
Comment 5 Manuel Rego Casasnovas 2021-01-25 02:03:06 PST 
The PR to be reviewed upstream is at: https://github.com/web-platform-tests/wpt/pull/27303
Comment 6 Ryosuke Niwa 2021-01-26 21:31:13 PST 
Comment on attachment 418255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review

> LayoutTests/imported/w3c/ChangeLog:18
> +        * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html.

Please unskip these tests in iOS.
Comment 7 Manuel Rego Casasnovas 2021-01-26 22:04:18 PST 
Created attachment 418509 [details]
Patch
Comment 8 Manuel Rego Casasnovas 2021-01-26 22:05:42 PST 
Comment on attachment 418255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418255&action=review

Thanks for the WPT review. Uploading new version unskipping tests in iOS.

>> LayoutTests/imported/w3c/ChangeLog:18
>> +        * web-platform-tests/shadow-dom/focus/focus-pseudo-on-shadow-host-3.html: Renamed from LayoutTests/fast/shadow-dom/focus-pseudo-on-shadow-host-3.html.
> 
> Please unskip these tests in iOS.

Done.
Comment 9 Ryosuke Niwa 2021-01-26 22:05:47 PST 
Let's wait for EWS.
Comment 10 Manuel Rego Casasnovas 2021-01-27 03:21:30 PST 
Comment on attachment 418509 [details]
Patch

Windows EWS failure is unrelated, so let's land this.
Comment 11 EWS 2021-01-27 03:41:25 PST 
Committed r271944: <https://trac.webkit.org/changeset/271944>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418509 [details].
Comment 12 Radar WebKit Bug Importer 2021-01-27 03:42:15 PST 
<rdar://problem/73656853>