Bug 220888 - [JSC] DeferredWorkTimer should clear pending task after running
Summary: [JSC] DeferredWorkTimer should clear pending task after running
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 21:22 PST by Yusuke Suzuki
Modified: 2021-01-23 14:12 PST (History)
7 users (show)

See Also:

Attachments
Patch (5.07 KB, patch)
2021-01-22 21:28 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (5.33 KB, patch)
2021-01-22 21:31 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (14.22 KB, patch)
2021-01-22 23:44 PST, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
Patch (14.22 KB, patch)
2021-01-23 02:18 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-22 21:22:26 PST 
[JSC] DeferredWorkTimer should clear pending task after running
Comment 1 Yusuke Suzuki 2021-01-22 21:28:15 PST 
Created attachment 418210 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-22 21:31:39 PST 
Created attachment 418211 [details]
Patch
Comment 3 Yusuke Suzuki 2021-01-22 23:12:08 PST 
Comment on attachment 418211 [details]
Patch

Looking.
Comment 4 Yusuke Suzuki 2021-01-22 23:44:00 PST 
Created attachment 418219 [details]
Patch
Comment 5 Yusuke Suzuki 2021-01-23 02:18:20 PST 
Created attachment 418220 [details]
Patch
Comment 6 Mark Lam 2021-01-23 11:33:59 PST 
Comment on attachment 418220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review

r=me

> Source/JavaScriptCore/runtime/JSPromise.cpp:-186
> -    vm.deferredWorkTimer->cancelPendingWork(this);

Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()?  I see that you've removed all calls to it.  If not, we should remove it.
Comment 7 Yusuke Suzuki 2021-01-23 14:07:48 PST 
Comment on attachment 418220 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418220&action=review

>> Source/JavaScriptCore/runtime/JSPromise.cpp:-186
>> -    vm.deferredWorkTimer->cancelPendingWork(this);
> 
> Is there a reason to still keep DeferredWorkTimer::cancelPendingWork()?  I see that you've removed all calls to it.  If not, we should remove it.

There are no users, so we can remove it :).
Comment 8 Yusuke Suzuki 2021-01-23 14:11:39 PST 
Committed r271781: <https://trac.webkit.org/changeset/271781>
Comment 9 Radar WebKit Bug Importer 2021-01-23 14:12:16 PST 
<rdar://problem/73539704>