Bug 220874 – Update availability annotations to match the macOS 11.0 and iOS 14.0 GM SDKs

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Update availability annotations to match the macOS 11.0 and iOS 14.0 GM SDKs.

[Chris Dumez]

<rdar://73474368>

[Chris Dumez]

Created attachment 418166 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 418166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418166&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:129
> +- (void)_webView:(WKWebView *)webView willGoToBackForwardListItem:(WKBackForwardListItem *)item inPageCache:(BOOL)inPageCache WK_API_AVAILABLE(macos(10.13.4), ios(14.0));

Can it really be that it's 10.13.4 on macOS, but a major release on iOS?

[Alex Christensen]

Comment on attachment 418166 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418166&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:129
>> +- (void)_webView:(WKWebView *)webView willGoToBackForwardListItem:(WKBackForwardListItem *)item inPageCache:(BOOL)inPageCache WK_API_AVAILABLE(macos(10.13.4), ios(14.0));
> 
> Can it really be that it's 10.13.4 on macOS, but a major release on iOS?

Yes.  See https://trac.webkit.org/changeset/260546/webkit

[Alexey Proskuryakov]

Comment on attachment 418166 [details]
Patch

Got it. Did we have anything shipped in update SDKs that needs to be annotated accordingly? Surprised to see no point update version in this patch.

[Chris Dumez]

(In reply to Alexey Proskuryakov from comment #5)
> Comment on attachment 418166 [details]
> Patch
> 
> Got it. Did we have anything shipped in update SDKs that needs to be
> annotated accordingly? Surprised to see no point update version in this
> patch.

I have no idea. It was already a pain to have to check which new API were in macOS 11.0 and iOS 14.0 one by one.

[Chris Dumez]

Created attachment 418310 [details]
Patch

[Chris Dumez]

Ok, I went further back to macOS 10.15.4 & iOS 13.4 (which was our last WebKit major release before macOS 11.0 & iOS 14.0).

[Darin Adler]

Comment on attachment 418310 [details]
Patch

Makes me wish we had a script to check our headers against the SDK. Tempted to write one.

[EWS]

Committed r271813: <https://trac.webkit.org/changeset/271813>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418310 [details].