RESOLVED FIXED220872
[WPT] [Payment Request] slight adjustment to payment-request/payment-request-constructor-thcrash.https.html 
https://bugs.webkit.org/show_bug.cgi?id=220872
Summary [WPT] [Payment Request] slight adjustment to payment-request/payment-request-...
Devin Rousso
Reported 2021-01-22 11:17:12 PST
I'm pretty sure the first test in payment-request/payment-request-constructor-thcrash.https.html is incorrect because duplicate items in `methodData` provided to `PaymentRequest` should throw a `RangeError` according to step 4.3.3 of <https://www.w3.org/TR/payment-request/#constructor>. The spec does mention in <https://www.w3.org/TR/payment-request/#conformance> > User agents _MAY_ impose implementation-specific limits on otherwise unconstrained inputs, e.g., to prevent denial of service attacks, to guard against running out of memory, or to work around platform-specific limitations. When an input exceeds implementation-specific limit, the user agent _MUST_ throw, or, in the context of a promise, reject with, a `TypeError` optionally informing the developer of how a particular input exceeded an implementation-specific limit. but does not specify whether this should happen before or after the above. In WebKit's case, there is no "implementation-specific limit", so WebKit shouldn't throw a `TypeError` regardless.
Attachments
Patch (2.75 KB, patch)
2021-01-22 11:19 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2021-01-22 11:22 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2021-01-22 11:24 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (2.75 KB, patch)
2021-01-22 11:24 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.90 KB, patch)
2021-01-22 12:54 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.90 KB, patch)
2021-01-22 12:56 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2021-01-22 11:19:00 PST
Created attachment 418158 [details] Patch
EWS Watchlist
Comment 2 2021-01-22 11:20:19 PST
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Devin Rousso
Comment 3 2021-01-22 11:22:51 PST
Created attachment 418161 [details] Patch
Devin Rousso
Comment 4 2021-01-22 11:24:05 PST
Created attachment 418162 [details] Patch
Devin Rousso
Comment 5 2021-01-22 11:24:37 PST
Created attachment 418163 [details] Patch
Devin Rousso
Comment 6 2021-01-22 12:54:21 PST
Created attachment 418172 [details] Patch
Devin Rousso
Comment 7 2021-01-22 12:56:20 PST
Created attachment 418173 [details] Patch
Devin Rousso
Comment 8 2021-01-22 12:56:50 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/27292
youenn fablet
Comment 9 2021-01-22 13:03:41 PST
Comment on attachment 418173 [details] Patch Let's r+ it again so that WPT bot gets it
EWS
Comment 10 2021-01-22 13:50:03 PST
Committed r271759: <https://trac.webkit.org/changeset/271759> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418173 [details].
Radar WebKit Bug Importer
Comment 11 2021-01-22 13:51:14 PST
<rdar://problem/73514233>
Note You need to log in before you can comment on or make changes to this bug.