Bug 220870 - [webkitpy][GTK] Xvfb driver fails to start with python3
Summary: [webkitpy][GTK] Xvfb driver fails to start with python3
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 11:11 PST by Lauro Moura
Modified: 2021-01-22 16:00 PST (History)
5 users (show)

See Also:


Attachments
Patch (3.39 KB, patch)
2021-01-22 13:41 PST, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2021-01-22 11:11:13 PST
Sample command:

python3 Tools/Scripts/run-webdriver-tests --verbose --gtk --release --display-server=xvfb 

Running inside flatpak gives the trace below. Hangs silently running from the desktop at the same point, regardless of inside Flatpak or outside it.

Traceback (most recent call last):
  File "Tools/Scripts/run-webdriver-tests", line 84, in <module>
    runner = WebDriverTestRunner(port)
  File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 63, in __init__
    env = self._display_driver._setup_environ_for_test()
  File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 99, in _setup_environ_for_test
    display_id = self._xvfb_run(port_server_environment)
  File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 87, in _xvfb_run
    display_id = self._xvfb_read_display_id(read_fd)
  File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 63, in _xvfb_read_display_id
    fd_list = select.select(fd_set, [], [])[0]
KeyboardInterrupt
Comment 1 Lauro Moura 2021-01-22 11:12:13 PST
Oops. There was bug210698 with the same issue. Closing this one.

*** This bug has been marked as a duplicate of bug 210698 ***
Comment 2 Lauro Moura 2021-01-22 11:13:26 PST
Actually, reopening to track in this one, as the description is more precise.

(Sorry for the noise)
Comment 3 Lauro Moura 2021-01-22 13:41:04 PST
Created attachment 418177 [details]
Patch
Comment 4 Lauro Moura 2021-01-22 13:43:58 PST
The style checker failed due to set_inheritable missing from the `os` module, but it's guarded by a check for py3.
Comment 5 EWS 2021-01-22 15:59:53 PST
Committed r271764: <https://trac.webkit.org/changeset/271764>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418177 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-22 16:00:15 PST
<rdar://problem/73519495>