Bug 220869 - Nullptr dereference in SpeechRecognition::stop()
Summary: Nullptr dereference in SpeechRecognition::stop()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 11:02 PST by Sihui Liu
Modified: 2021-01-25 04:31 PST (History)
7 users (show)

See Also:

Attachments
Patch (1.66 KB, patch)
2021-01-22 11:19 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (1.66 KB, patch)
2021-01-22 11:21 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (3.71 KB, patch)
2021-01-22 18:35 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (3.71 KB, patch)
2021-01-24 17:24 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2021-01-22 11:02:01 PST 
...
Comment 1 Radar WebKit Bug Importer 2021-01-22 11:02:12 PST Comment hidden (obsolete)
Comment 2 Sihui Liu 2021-01-22 11:19:29 PST 
Created attachment 418159 [details]
Patch
Comment 3 Sihui Liu 2021-01-22 11:20:40 PST 
<rdar://problem/73403469>
Comment 4 Sihui Liu 2021-01-22 11:21:07 PST 
Created attachment 418160 [details]
Patch
Comment 5 Ryosuke Niwa 2021-01-22 12:38:51 PST 
Comment on attachment 418160 [details]
Patch

Is there a security issue? If not, can we add a test?
Comment 6 youenn fablet 2021-01-22 13:46:34 PST 
It seems a test can be added if this is about frameless document.
Comment 7 Sihui Liu 2021-01-22 18:35:29 PST 
Created attachment 418205 [details]
Patch
Comment 8 Ryosuke Niwa 2021-01-22 22:05:38 PST 
Comment on attachment 418205 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418205&action=review

> LayoutTests/fast/speechrecognition/detached-iframe.html:8
> +
> +

Two blank lines.

> LayoutTests/fast/speechrecognition/detached-iframe.html:11
> +if (window.testRunner) {
> +    jsTestIsAsync = true;
> +}

No curly braces around a single line statement.

> LayoutTests/fast/speechrecognition/detached-iframe.html:14
> +	var frame = document.getElementById('iframe');

Use const?
Comment 9 Sihui Liu 2021-01-24 17:24:56 PST 
Created attachment 418247 [details]
Patch for landing
Comment 10 EWS 2021-01-24 17:59:58 PST 
commit-queue failed to commit attachment 418247 [details] to WebKit repository.
Comment 11 EWS 2021-01-25 04:31:04 PST 
Committed r271791: <https://trac.webkit.org/changeset/271791>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418247 [details].