Bug 220868 - REGRESSION (r271731): Unchecked JS exception under GlobalObject::moduleLoaderFetch
Summary: REGRESSION (r271731): Unchecked JS exception under GlobalObject::moduleLoader...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 10:54 PST by Ryan Haddad
Modified: 2021-01-22 16:07 PST (History)
9 users (show)

See Also:

Attachments
Patch (46.90 KB, patch)
2021-01-22 14:03 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2021-01-22 10:54:58 PST 
After https://trac.webkit.org/changeset/271731/webkit landed, the debug JSC bot has thousands of test failing with the following:

ERROR: Unchecked JS exception:
    This scope can throw a JS exception: resolve @ ./runtime/JSPromise.cpp:162
        (ExceptionScope::m_recursionDepth was 13)
    But the exception was unchecked as of this scope: moduleLoaderFetch @ /Volumes/Data/slave/catalina-debug/build/Source/JavaScriptCore/jsc.cpp:1184
        (ExceptionScope::m_recursionDepth was 12)

Unchecked exception detected at:
    1   0x10796343e JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation&)
    2   0x10752de11 JSC::CatchScope::~CatchScope()
    3   0x10752db65 JSC::CatchScope::~CatchScope()
    4   0x105b17bf3 GlobalObject::moduleLoaderFetch(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSValue, JSC::JSValue, JSC::JSValue)
    5   0x1077755b5 JSC::JSModuleLoader::fetch(JSC::JSGlobalObject*, JSC::JSValue, JSC::JSValue, JSC::JSValue)
    6   0x10777b51d JSC::moduleLoaderFetch(JSC::JSGlobalObject*, JSC::CallFrame*)
    7   0x5af48d801178
    8   0x1062f4eb2 llint_entry
    9   0x1062f4eb2 llint_entry
    10  0x1062f4eb2 llint_entry
    11  0x1062f4eb2 llint_entry
    12  0x1062f4eb2 llint_entry
    13  0x1062f4eb2 llint_entry
    14  0x1062d3740 vmEntryToJavaScript
    15  0x1071bfefb JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
    16  0x1071c06b7 JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
    17  0x10752d90d JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
    18  0x107774a22 JSC::JSModuleLoader::requestImportModule(JSC::JSGlobalObject*, JSC::Identifier const&, JSC::JSValue, JSC::JSValue)
    19  0x1075a5495 JSC::importModule(JSC::JSGlobalObject*, JSC::Identifier const&, JSC::JSValue, JSC::JSValue)
    20  0x105b170df GlobalObject::moduleLoaderImportModule(JSC::JSGlobalObject*, JSC::JSModuleLoader*, JSC::JSString*, JSC::JSValue, JSC::SourceOrigin const&)
    21  0x107774c0f JSC::JSModuleLoader::importModule(JSC::JSGlobalObject*, JSC::JSString*, JSC::JSValue, JSC::SourceOrigin const&)
    22  0x107711830 JSC::globalFuncImportModule(JSC::JSGlobalObject*, JSC::CallFrame*)
    23  0x5af48d801178
    24  0x1062f4eb2 llint_entry
    25  0x1062d3740 vmEntryToJavaScript
    26  0x1071bfefb JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
    27  0x1071bf452 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::JSGlobalObject*, JSC::JSObject*)
    28  0x1075a43b7 JSC::evaluate(JSC::JSGlobalObject*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
    29  0x105b8dab3 runWithOptions(GlobalObject*, CommandLine&, bool&)
    30  0x105b491ea jscmain(int, char**)::$_10::operator()(JSC::VM&, GlobalObject*, bool&) const
    31  0x105b1d7a3 int runJSC<jscmain(int, char**)::$_10>(CommandLine const&, bool, jscmain(int, char**)::$_10 const&)
    32  0x105b1b1f2 jscmain(int, char**)
    33  0x105b1af2e main
    34  0x7fff6e98ecc9 start


https://build.webkit.org/builders/Apple-Catalina-Debug-JSC-Tests/builds/2224/steps/jscore-test/logs/stdio
Comment 1 Radar WebKit Bug Importer 2021-01-22 10:55:07 PST 
<rdar://problem/73506709>
Comment 2 Yusuke Suzuki 2021-01-22 14:03:20 PST 
Created attachment 418179 [details]
Patch
Comment 3 Mark Lam 2021-01-22 14:52:15 PST 
Comment on attachment 418179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418179&action=review

r=me

> Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp:244
> +            JSC::instantiate(vm, globalObject, promise, module, importObject, moduleKey, resolveKind, creationMode);

I think we don't need this JSC:: qualifier.
Comment 4 Yusuke Suzuki 2021-01-22 14:53:51 PST 
Comment on attachment 418179 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418179&action=review

>> Source/JavaScriptCore/wasm/js/JSWebAssembly.cpp:244
>> +            JSC::instantiate(vm, globalObject, promise, module, importObject, moduleKey, resolveKind, creationMode);
> 
> I think we don't need this JSC:: qualifier.

Removed
Comment 5 Yusuke Suzuki 2021-01-22 16:07:39 PST 
Committed r271766: <https://trac.webkit.org/changeset/271766>