WIP for #219097.
Created attachment 418157 [details] Patch
Comment on attachment 418157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418157&action=review > Source/WebCore/platform/graphics/displaylists/DisplayList.h:129 > + m_isValid ? Optional<ItemHandle> {{ m_currentBufferForItem }} : WTF::nullopt, nit: makeOptional() may look nicer. > Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:42 > +static constexpr CGFloat contextWidth = 100; static is not needed since global & const. > Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:43 > +static constexpr CGFloat contextHeight = 100; ditto.
Comment on attachment 418157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418157&action=review Thanks for the review! >> Source/WebCore/platform/graphics/displaylists/DisplayList.h:129 >> + m_isValid ? Optional<ItemHandle> {{ m_currentBufferForItem }} : WTF::nullopt, > > nit: makeOptional() may look nicer. Changed to use makeOptional(). >> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:42 >> +static constexpr CGFloat contextWidth = 100; > > static is not needed since global & const. Removed the static. >> Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp:43 >> +static constexpr CGFloat contextHeight = 100; > > ditto. 👍🏻
Created attachment 418168 [details] Patch for landing
commit-queue failed to commit attachment 418168 [details] to WebKit repository.
Committed r271757: <https://trac.webkit.org/changeset/271757>
<rdar://problem/73511358>