Bug 220856 - TransformationMatrix::Recompose() and Decompose() incorrectly transpose rotation
Summary: TransformationMatrix::Recompose() and Decompose() incorrectly transpose rotation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Woodrow
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-22 03:05 PST by Imanol Fernandez
Modified: 2023-08-29 14:45 PDT (History)
7 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Imanol Fernandez 2021-01-22 03:05:45 PST 
The computation of quaternions during matrix decomposition looks like it's based off of the matrix transpose. The matrix data is actually column major order but the quaternion operations seem to assume row major order.

More info in the equivalent chromium bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=929841
Comment 1 Radar WebKit Bug Importer 2021-01-29 03:06:11 PST 
<rdar://problem/73747851>
Comment 2 Matt Woodrow 2023-08-28 18:03:58 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/17162
Comment 3 EWS 2023-08-29 14:45:25 PDT 
Committed 267424@main (a959acf1111c): <https://commits.webkit.org/267424@main>

Reviewed commits have been landed. Closing PR #17162 and removing active labels.