Bug 220847 - MotionMark scores are super sensitive to a single long frame
Summary: MotionMark scores are super sensitive to a single long frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 222449
Blocks:
  Show dependency tree / graph
 
Reported: 2021-01-22 00:50 PST by Myles C. Maxfield
Modified: 2021-03-09 15:50 PST (History)
9 users (show)

See Also:

Attachments
WIP (6.79 KB, patch)
2021-01-22 00:58 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.77 KB, patch)
2021-02-16 15:48 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (10.08 KB, patch)
2021-03-07 23:45 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (10.08 KB, patch)
2021-03-08 11:06 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (8.10 KB, patch)
2021-03-09 02:10 PST, Myles C. Maxfield 		jonlee: review+
Details | Formatted Diff | Diff
Patch for committing (8.22 KB, patch)
2021-03-09 14:16 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch for committing (8.22 KB, patch)
2021-03-09 14:16 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-01-22 00:50:42 PST 
MotionMark scores are super sensitive to a single long frame
Comment 1 Myles C. Maxfield 2021-01-22 00:58:13 PST 
Created attachment 418116 [details]
WIP
Comment 2 Myles C. Maxfield 2021-01-27 19:39:08 PST 

*** This bug has been marked as a duplicate of bug 221075 ***
Comment 3 Myles C. Maxfield 2021-02-16 15:42:34 PST 
Reopening because the problem seems to still exist after r272044
Comment 4 Myles C. Maxfield 2021-02-16 15:46:30 PST 
<rdar://problem/74152743>
Comment 5 Myles C. Maxfield 2021-02-16 15:48:23 PST 
Created attachment 420553 [details]
Patch
Comment 6 Maciej Stachowiak 2021-02-17 15:59:09 PST 
Comment on attachment 420553 [details]
Patch

I'm not an expert on MotionMark, but to the extent I understand the intent of this patch, it seems to do what its supposed to.
Comment 7 Jon Lee 2021-02-18 00:23:49 PST 
lgtm.
Comment 8 Myles C. Maxfield 2021-02-18 19:30:03 PST 
Committed r273122 (234319@main): <https://commits.webkit.org/234319@main>
Comment 9 Myles C. Maxfield 2021-02-18 19:35:24 PST 
Committed r273123 (234320@main): <https://commits.webkit.org/234320@main>
Comment 10 WebKit Commit Bot 2021-02-25 18:39:04 PST 
Re-opened since this is blocked by bug 222449
Comment 11 Myles C. Maxfield 2021-03-07 23:45:07 PST 
Created attachment 422546 [details]
Patch
Comment 12 Myles C. Maxfield 2021-03-08 11:06:06 PST 
Created attachment 422587 [details]
Patch
Comment 13 Myles C. Maxfield 2021-03-09 02:10:01 PST 
Created attachment 422681 [details]
Patch
Comment 14 Myles C. Maxfield 2021-03-09 13:41:56 PST 
Comment on attachment 422681 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422681&action=review

> PerformanceTests/ChangeLog:17
> +        a complexity that was 3.16x of the previous complexity. This patch changes that to 1.5x of the previous

Whoops, this is actually 1.778x
Comment 15 Myles C. Maxfield 2021-03-09 14:16:04 PST 
Created attachment 422756 [details]
Patch for committing
Comment 16 Myles C. Maxfield 2021-03-09 14:16:57 PST 
Created attachment 422757 [details]
Patch for committing
Comment 17 EWS 2021-03-09 15:08:46 PST 
Committed r274179: <https://commits.webkit.org/r274179>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422757 [details].
Comment 18 Myles C. Maxfield 2021-03-09 15:50:26 PST 
Committed r274183 (235102@main): <https://commits.webkit.org/235102@main>