Bug 220846 - WebGL powerPreference is not tested
Summary: WebGL powerPreference is not tested
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on: 220843
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-22 00:16 PST by Kimmo Kinnunen
Modified: 2021-07-26 13:47 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.11 KB, patch)
2021-01-22 00:23 PST, Kimmo Kinnunen
kbr: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-01-22 00:16:23 PST
Needs
 - tests
 - interface to check if integrated GPU is on
 - interface to check if has discrete GPU
 - interface to flush the shutdown timer of discrete GPU
Comment 1 Kimmo Kinnunen 2021-01-22 00:23:21 PST
Created attachment 418113 [details]
Patch
Comment 2 Kenneth Russell 2021-01-23 00:25:02 PST
Comment on attachment 418113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418113&action=review

Looks good to me. r+

> LayoutTests/fast/canvas/webgl/high-performance-context.html:14
> +description("Tests that a high-performance contexts do not fail.");

"contexts do not" -> "context does not"

> LayoutTests/fast/canvas/webgl/high-performance-context.html:19
> +var wtu = WebGLTestUtils;

Nowadays, prefer "let" (or "const") over "var".
Comment 4 Radar WebKit Bug Importer 2021-01-29 00:17:17 PST
<rdar://problem/73744012>