Bug 220839 - [WebAuthn] No error is visible after user enters the incorrect PIN
Summary: [WebAuthn] No error is visible after user enters the incorrect PIN
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency tree / graph
 
Reported: 2021-01-21 18:44 PST by Jiewen Tan
Modified: 2021-01-22 12:04 PST (History)
3 users (show)

See Also:

Attachments
Patch (3.37 KB, patch)
2021-01-21 18:48 PST, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-01-21 18:44:17 PST 
When entering an incorrect PIN for a security key, the “incorrect PIN” error message gets flashed very briefly on screen before being dismissed and replaced with the original PIN entry view.
Comment 1 Jiewen Tan 2021-01-21 18:44:27 PST 
<rdar://problem/73378319>
Comment 2 Jiewen Tan 2021-01-21 18:48:47 PST 
Created attachment 418104 [details]
Patch
Comment 3 Brent Fulgham 2021-01-22 11:54:38 PST 
Comment on attachment 418104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418104&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:159
> +    if (m_presentedPIN)

You might want to add a logging message so we can debug failed PIN cases in the future.
Comment 4 Jiewen Tan 2021-01-22 12:00:37 PST 
Comment on attachment 418104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418104&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:159
>> +    if (m_presentedPIN)
> 
> You might want to add a logging message so we can debug failed PIN cases in the future.

Good idea! Not sure if this is the good place. I think I have some logging in the caller site.
Comment 5 EWS 2021-01-22 12:04:11 PST 
Committed r271754: <https://trac.webkit.org/changeset/271754>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418104 [details].