Bug 220830 - textarea can't handle switch direction
Summary: textarea can't handle switch direction
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari 14
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL: data:text/html,<textarea id=textarea>...
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-21 14:37 PST by Ebrahim Byagowi
Modified: 2024-09-08 20:41 PDT (History)
10 users (show)

See Also:


Attachments
actual (178.61 KB, image/png)
2021-01-21 14:37 PST, Ebrahim Byagowi
no flags Details
Patch (4.39 KB, patch)
2024-09-08 14:42 PDT, zalan
no flags Details | Formatted Diff | Diff
[fast-cq]Patch (5.08 KB, patch)
2024-09-08 18:22 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ebrahim Byagowi 2021-01-21 14:37:11 PST
Created attachment 418087 [details]
actual

Open
data:text/html,<textarea id=textarea>a%0Ab%0Ac</textarea><button onclick="textarea.dir=textarea.dir==='rtl'?'ltr':'rtl'">Switch</button><br><textarea>a%0Ab%0Ac</textarea><br><textarea dir=rtl>a%0Ab%0Ac</textarea>

Use switch button or right click switch textarea's direction from Paragraph Direction

Expected:
Like other browsers, not confused expand icon, to have the first like the third after switch button being hit.

Actual:
The used expand icon is confused when direction is changed. Also the scrollbar's animation isn't correct.
Comment 1 Ebrahim Byagowi 2021-01-21 14:39:24 PST
Not that impacting but hit me while using Safari on some site so will try to work on this myself but helps would be nice :)
Comment 2 Smoley 2021-01-21 16:43:24 PST
Thanks for filing, I can reproduce this on Safari 13.1.3 and STP 118.
Comment 3 Radar WebKit Bug Importer 2021-01-21 16:43:42 PST
<rdar://problem/73475239>
Comment 4 Sam Sneddon [:gsnedders] 2021-01-22 11:33:50 PST
Note that this appears to be specifically when the the textarea has overflow. If you expand the textarea before changing its direction such that there is no overflow, this doesn't reproduce.

I think :smfr has been working on overflow-related stuff recently, so CC'ing him.
Comment 5 zalan 2024-09-08 14:42:27 PDT
Created attachment 472494 [details]
Patch
Comment 6 zalan 2024-09-08 18:22:58 PDT
Created attachment 472497 [details]
[fast-cq]Patch
Comment 7 EWS 2024-09-08 19:36:00 PDT
Committed 283327@main (7a6719898c9a): <https://commits.webkit.org/283327@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 472497 [details].