Bug 220813 - Null dereference in CompositeEditCommand::cloneParagraphUnderNewElement(): needs to check lastNode parent
Summary: Null dereference in CompositeEditCommand::cloneParagraphUnderNewElement(): ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-21 12:31 PST by Julian Gonzalez
Modified: 2021-01-21 15:43 PST (History)
4 users (show)

See Also:

Attachments
Patch (4.44 KB, patch)
2021-01-21 12:42 PST, Julian Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Gonzalez 2021-01-21 12:31:07 PST 
e.g.

frame #0: WebCore`WebCore::Node::parentNode() const+0
frame #1: WebCore`WebCore::CompositeEditCommand::cloneParagraphUnderNewElement(WebCore::Position const&, WebCore::Position const&, WebCore::Node*, WebCore::Element*)+0
frame #2: WebCore`WebCore::CompositeEditCommand::moveParagraphWithClones(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::Element*, WebCore::Node*)+0
frame #3: WebCore`WebCore::IndentOutdentCommand::indentIntoBlockquote(WebCore::Position const&, WebCore::Position const&, WTF::RefPtr<WebCore::Element, WTF::DumbPtrTraits<WebCore::Element> >&)+0
frame #4: WebCore`WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)+0
frame #5: WebCore`WebCore::ApplyBlockElementCommand::doApply()+0
frame #6: WebCore`WebCore::CompositeEditCommand::apply()+0
frame #7: WebCore`WebCore::executeIndent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+0
frame #8: WebCore`WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+0

<rdar://problem/66894117>
Comment 1 Julian Gonzalez 2021-01-21 12:42:26 PST 
Created attachment 418070 [details]
Patch
Comment 2 Julian Gonzalez 2021-01-21 15:42:58 PST 
Real radar:

<rdar://problem/72194329>
Comment 3 EWS 2021-01-21 15:43:28 PST 
Committed r271720: <https://trac.webkit.org/changeset/271720>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418070 [details].