Bug 220811 - Add WebXR to features.json
Summary: Add WebXR to features.json
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-21 11:20 PST by Myles C. Maxfield
Modified: 2021-01-21 16:13 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.81 KB, patch)
2021-01-21 11:22 PST, Myles C. Maxfield 		simon.fraser: review+
Details | Formatted Diff | Diff
Patch for committing (1.77 KB, patch)
2021-01-21 11:49 PST, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2021-01-21 11:20:05 PST 
Add WebXR to features.json
Comment 1 Myles C. Maxfield 2021-01-21 11:22:01 PST 
Created attachment 418065 [details]
Patch
Comment 2 Simon Fraser (smfr) 2021-01-21 11:29:29 PST 
Comment on attachment 418065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review

> Source/WebCore/features.json:822
> +            "enabled-by-default": true

Let's remove this.

> Source/WebCore/features.json:826
> +        "keywords": ["webxr", "webgl", "webgpu"],

are webgl and webgpu relevant?
Comment 3 Myles C. Maxfield 2021-01-21 11:33:05 PST 
Comment on attachment 418065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review

>> Source/WebCore/features.json:826
>> +        "keywords": ["webxr", "webgl", "webgpu"],
> 
> are webgl and webgpu relevant?

yes! XR without webgl/webgpu is hardly an XR at all!
Comment 4 Myles C. Maxfield 2021-01-21 11:49:12 PST 
Created attachment 418066 [details]
Patch for committing
Comment 5 Dean Jackson 2021-01-21 12:09:22 PST 
Comment on attachment 418065 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&action=review

>> Source/WebCore/features.json:822
>> +            "enabled-by-default": true
> 
> Let's remove this.

it's definitely not on by default
Comment 6 EWS 2021-01-21 16:12:52 PST 
Committed r271721: <https://trac.webkit.org/changeset/271721>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418066 [details].
Comment 7 Radar WebKit Bug Importer 2021-01-21 16:13:14 PST 
<rdar://problem/73473944>