WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
220785
Further propagate ChildChange::Source to optimize HTMLInputElement creation
https://bugs.webkit.org/show_bug.cgi?id=220785
Summary
Further propagate ChildChange::Source to optimize HTMLInputElement creation
Yusuke Suzuki
Reported
2021-01-20 19:42:29 PST
Further propagate ChildChange::Source to optimize HTMLInputElement creation
Attachments
Patch
(22.64 KB, patch)
2021-01-20 19:43 PST
,
Yusuke Suzuki
rniwa
: review+
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(10.14 KB, patch)
2021-01-20 20:53 PST
,
Yusuke Suzuki
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2021-01-20 19:43:43 PST
Created
attachment 418014
[details]
Patch
Ryosuke Niwa
Comment 2
2021-01-20 20:04:20 PST
Comment on
attachment 418014
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418014&action=review
Hm... it's a bit scary because parser* variants aren't safe to use in some cases but we'd see how it goes.
> Source/WebCore/dom/ContainerNode.cpp:494 > + // insertBefore(node, null) is equivalent to appendChild(node)
I don't think we need this comment. Remove?
Yusuke Suzuki
Comment 3
2021-01-20 20:37:51 PST
Comment on
attachment 418014
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=418014&action=review
Yes, I tried removing scary things, and attempt to use it in a safe places now. Uploading.
>> Source/WebCore/dom/ContainerNode.cpp:494 >> + // insertBefore(node, null) is equivalent to appendChild(node) > > I don't think we need this comment. Remove?
Removed.
Yusuke Suzuki
Comment 4
2021-01-20 20:53:34 PST
Created
attachment 418021
[details]
Patch
Yusuke Suzuki
Comment 5
2021-01-20 22:32:37 PST
Committed
r271686
: <
https://trac.webkit.org/changeset/271686
>
Radar WebKit Bug Importer
Comment 6
2021-01-20 22:33:13 PST
<
rdar://problem/73437900
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug