Bug 220785 - Further propagate ChildChange::Source to optimize HTMLInputElement creation
Summary: Further propagate ChildChange::Source to optimize HTMLInputElement creation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on: 220758
Blocks:
  Show dependency treegraph
 
Reported: 2021-01-20 19:42 PST by Yusuke Suzuki
Modified: 2021-01-20 22:33 PST (History)
11 users (show)

See Also:


Attachments
Patch (22.64 KB, patch)
2021-01-20 19:43 PST, Yusuke Suzuki
rniwa: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2021-01-20 20:53 PST, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-20 19:42:29 PST
Further propagate ChildChange::Source to optimize HTMLInputElement creation
Comment 1 Yusuke Suzuki 2021-01-20 19:43:43 PST
Created attachment 418014 [details]
Patch
Comment 2 Ryosuke Niwa 2021-01-20 20:04:20 PST
Comment on attachment 418014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418014&action=review

Hm... it's a bit scary because parser* variants aren't safe to use in some cases but we'd see how it goes.

> Source/WebCore/dom/ContainerNode.cpp:494
> +        // insertBefore(node, null) is equivalent to appendChild(node)

I don't think we need this comment. Remove?
Comment 3 Yusuke Suzuki 2021-01-20 20:37:51 PST
Comment on attachment 418014 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418014&action=review

Yes, I tried removing scary things, and attempt to use it in a safe places now. Uploading.

>> Source/WebCore/dom/ContainerNode.cpp:494
>> +        // insertBefore(node, null) is equivalent to appendChild(node)
> 
> I don't think we need this comment. Remove?

Removed.
Comment 4 Yusuke Suzuki 2021-01-20 20:53:34 PST
Created attachment 418021 [details]
Patch
Comment 5 Yusuke Suzuki 2021-01-20 22:32:37 PST
Committed r271686: <https://trac.webkit.org/changeset/271686>
Comment 6 Radar WebKit Bug Importer 2021-01-20 22:33:13 PST
<rdar://problem/73437900>