Bug 220783 - Form payloads with text/plain enctype should have a final \r\n
Summary: Form payloads with text/plain enctype should have a final \r\n
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 17:16 PST by Andreu Botella
Modified: 2021-11-29 10:15 PST (History)
9 users (show)

See Also:


Attachments
Patch (18.66 KB, patch)
2021-11-14 11:02 PST, Andreu Botella
no flags Details | Formatted Diff | Diff
Patch (18.77 KB, patch)
2021-11-14 19:28 PST, Andreu Botella
no flags Details | Formatted Diff | Diff
Patch (20.17 KB, patch)
2021-11-15 12:25 PST, Andreu Botella
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreu Botella 2021-01-20 17:16:38 PST
Text/plain form payloads have entries separated by a \r\n newline, but the HTML specification (https://html.spec.whatwg.org/#plain-text-form-data) requires there to be a final \r\n newline, which WebKit skips.

Tests: https://wpt.fyi/results/html/semantics/forms/form-submission-0/text-plain.window.html?label=pr_head&max-count=1&pr=26740
(ignore the "formdata event" tests, since those are meant to test entries added to the form entry list through the formdata event, which WebKit doesn't yet implement)
Comment 1 Radar WebKit Bug Importer 2021-01-21 16:45:16 PST
<rdar://problem/73475295>
Comment 2 Andreu Botella 2021-11-14 11:02:57 PST
Created attachment 444180 [details]
Patch
Comment 3 Andreu Botella 2021-11-14 19:28:43 PST
Created attachment 444207 [details]
Patch
Comment 4 Andreu Botella 2021-11-15 12:25:12 PST
Created attachment 444292 [details]
Patch
Comment 5 EWS 2021-11-29 10:15:19 PST
Committed r286221 (244602@main): <https://commits.webkit.org/244602@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444292 [details].