Bug 220782 - [macOS] Include an origin identifier when writing promised image data to the drag pasteboard
Summary: [macOS] Include an origin identifier when writing promised image data to the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 15:52 PST by Wenson Hsieh
Modified: 2021-01-20 19:31 PST (History)
5 users (show)

See Also:

Attachments
Patch (19.31 KB, patch)
2021-01-20 16:00 PST, Wenson Hsieh 		megan_gardner: review+
Details | Formatted Diff | Diff
Patch for landing (19.30 KB, patch)
2021-01-20 18:47 PST, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-01-20 15:52:36 PST 
Needed to avoid regressing the layout test editing/pasteboard/drag-and-drop-objectimage-contenteditable.html after the changes in bug #215399
Comment 1 Wenson Hsieh 2021-01-20 16:00:25 PST 
Created attachment 418002 [details]
Patch
Comment 2 Megan Gardner 2021-01-20 16:21:44 PST 
Comment on attachment 418002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418002&action=review

> Source/WebKit/UIProcess/mac/PageClientImplMac.h:104
> +        const String& url, const String& visibleUrl, RefPtr<WebCore::SharedBuffer>&& archiveBuffer, const String& originIdentifier) override;

Caps URL here like above?
Comment 3 Wenson Hsieh 2021-01-20 16:53:48 PST 
(In reply to Megan Gardner from comment #2)
> Comment on attachment 418002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418002&action=review
> 
> > Source/WebKit/UIProcess/mac/PageClientImplMac.h:104
> > +        const String& url, const String& visibleUrl, RefPtr<WebCore::SharedBuffer>&& archiveBuffer, const String& originIdentifier) override;
> 
> Caps URL here like above?

Good catch! Changed to visibleURL.
Comment 4 Wenson Hsieh 2021-01-20 18:47:10 PST 
Created attachment 418013 [details]
Patch for landing
Comment 5 EWS 2021-01-20 19:30:02 PST 
Committed r271685: <https://trac.webkit.org/changeset/271685>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418013 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-20 19:31:15 PST 
<rdar://problem/73432762>