Bug 220778 - Forbid '|' in URL hosts
Summary: Forbid '|' in URL hosts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 12:50 PST by Alex Christensen
Modified: 2021-01-26 13:15 PST (History)
7 users (show)

See Also:

Attachments
Patch (21.80 KB, patch)
2021-01-20 12:53 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (22.36 KB, patch)
2021-01-20 12:57 PST, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (23.48 KB, patch)
2021-01-20 17:07 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (30.35 KB, patch)
2021-01-26 10:26 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-01-20 12:50:49 PST 
Forbid '|' in URL hosts
Comment 1 Alex Christensen 2021-01-20 12:53:04 PST 
Created attachment 417990 [details]
Patch
Comment 2 EWS Watchlist 2021-01-20 12:54:09 PST 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Alex Christensen 2021-01-20 12:57:59 PST 
Created attachment 417991 [details]
Patch
Comment 4 Alex Christensen 2021-01-20 17:07:39 PST 
Created attachment 418006 [details]
Patch
Comment 5 youenn fablet 2021-01-20 23:52:28 PST 
Comment on attachment 418006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review

> LayoutTests/fast/url/file-http-base-expected.txt:13
> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar.

Should we update this test?
Comment 6 Alex Christensen 2021-01-21 09:18:19 PST 
Comment on attachment 418006 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418006&action=review

>> LayoutTests/fast/url/file-http-base-expected.txt:13
>> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar.
> 
> Should we update this test?

I don't think so.  It failed before and after, and most of the tests in this file fail.
Comment 7 EWS 2021-01-21 09:21:32 PST 
commit-queue failed to commit attachment 418006 [details] to WebKit repository.
Comment 8 youenn fablet 2021-01-21 09:25:03 PST 
(In reply to Alex Christensen from comment #6)
> Comment on attachment 418006 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418006&action=review
> 
> >> LayoutTests/fast/url/file-http-base-expected.txt:13
> >> +FAIL canonicalize('//C|/foo/bar') should be file:///C:/foo/bar. Was //C|/foo/bar.
> > 
> > Should we update this test?
> 
> I don't think so.  It failed before and after, and most of the tests in this
> file fail.

So we should probably update the test so as to PASS (or remove the test).
Comment 9 Alex Christensen 2021-01-26 10:26:12 PST 
Created attachment 418443 [details]
Patch
Comment 10 EWS 2021-01-26 13:14:39 PST 
Committed r271899: <https://trac.webkit.org/changeset/271899>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418443 [details].
Comment 11 Radar WebKit Bug Importer 2021-01-26 13:15:18 PST 
<rdar://problem/73629875>