Bug 220777 - [macOS] The development WebContent XPC service crashes under WebKit::AuxiliaryProcess::initializeSandbox
Summary: [macOS] The development WebContent XPC service crashes under WebKit::Auxiliar...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 11:49 PST by Per Arne Vollan
Modified: 2021-01-25 11:10 PST (History)
3 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2021-01-20 12:01 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (16.67 KB, patch)
2021-01-20 12:51 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Patch (16.63 KB, patch)
2021-01-20 14:23 PST, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2021-01-20 11:49:31 PST 
This happens because the development XPC service does not have the required private entitlement to enable message filtering in the sandbox, and therefore fails to apply the sandbox. The existing runtime switching to enable message filtering based on the presence of the entitlement is not working correctly.
Comment 1 Per Arne Vollan 2021-01-20 11:50:06 PST 
<rdar://problem/73382584>
Comment 2 Per Arne Vollan 2021-01-20 12:01:10 PST 
Created attachment 417986 [details]
Patch
Comment 3 Per Arne Vollan 2021-01-20 12:51:24 PST 
Created attachment 417989 [details]
Patch
Comment 4 Per Arne Vollan 2021-01-20 14:23:47 PST 
Created attachment 417996 [details]
Patch
Comment 5 Brent Fulgham 2021-01-21 10:41:44 PST 
Comment on attachment 417996 [details]
Patch

r=me
Comment 6 Per Arne Vollan 2021-01-21 11:25:05 PST 
(In reply to Brent Fulgham from comment #5)
> Comment on attachment 417996 [details]
> Patch
> 
> r=me

Thanks for reviewing!
Comment 7 EWS 2021-01-21 12:35:10 PST 
Committed r271710: <https://trac.webkit.org/changeset/271710>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417996 [details].
Comment 8 Alexey Proskuryakov 2021-01-21 18:31:43 PST 
Comment on attachment 417996 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417996&action=review

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-121
> -#if HAVE(SANDBOX_MESSAGE_FILTERING)

I'm surprised by the removal of compile time check. But I guess it's OK given that EWS is green.
Comment 9 Per Arne Vollan 2021-01-25 11:10:00 PST 
(In reply to Alexey Proskuryakov from comment #8)
> Comment on attachment 417996 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417996&action=review
> 
> > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:-121
> > -#if HAVE(SANDBOX_MESSAGE_FILTERING)
> 
> I'm surprised by the removal of compile time check. But I guess it's OK
> given that EWS is green.

This should now be handled at compile time of the sandbox.

Thanks for reviewing!