Bug 220769 – EWS should display commit identifier in builds

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

We recently added a new commit identifier to identify commits in WebKit git repository. We also moved EWS to use github.com checkout on the bots (https://bugs.webkit.org/show_bug.cgi?id=220479). We should now change EWS to display these commit identifiers.

[Aakash Jain]

Created attachment 417995 [details]
Patch

[Aakash Jain]

Sample runs:
Builder queue: https://ews-build.webkit-uat.org/#/builders/35/builds/84512 
Tester queue: https://ews-build.webkit-uat.org/#/builders/34/builds/21300

[Jonathan Bedard]

Comment on attachment 417995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417995&action=review

> Tools/CISupport/ews-build/steps.py:179
> +        revision = self.getProperty('ews_revision', self.getProperty('got_revision'))

This is actually the commit hash, right?

> Tools/CISupport/ews-build/steps.py:182
> +        self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])

Should we consider invoking this with python3?

[Aakash Jain]

(In reply to Jonathan Bedard from comment #3)
> This is actually the commit hash, right?
Yes
> Should we consider invoking this with python3?
I am not sure if all the bots (including external bots) having python 3. Might be a good idea to verify that and do it in separate patch.

[EWS]

Committed r271675: <https://trac.webkit.org/changeset/271675>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417995 [details].

[Radar WebKit Bug Importer]

<rdar://problem/73422109>