Bug 220769 - EWS should display commit identifier in builds
Summary: EWS should display commit identifier in builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-20 09:13 PST by Aakash Jain
Modified: 2021-01-20 15:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (24.05 KB, patch)
2021-01-20 14:10 PST, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2021-01-20 09:13:41 PST
We recently added a new commit identifier to identify commits in WebKit git repository. We also moved EWS to use github.com checkout on the bots (https://bugs.webkit.org/show_bug.cgi?id=220479). We should now change EWS to display these commit identifiers.
Comment 1 Aakash Jain 2021-01-20 14:10:56 PST
Created attachment 417995 [details]
Patch
Comment 3 Jonathan Bedard 2021-01-20 14:20:39 PST
Comment on attachment 417995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417995&action=review

> Tools/CISupport/ews-build/steps.py:179
> +        revision = self.getProperty('ews_revision', self.getProperty('got_revision'))

This is actually the commit hash, right?

> Tools/CISupport/ews-build/steps.py:182
> +        self.setCommand(['python', 'Tools/Scripts/git-webkit', '-C', 'https://github.com/WebKit/Webkit', 'find', revision])

Should we consider invoking this with python3?
Comment 4 Aakash Jain 2021-01-20 14:22:50 PST
(In reply to Jonathan Bedard from comment #3)
> This is actually the commit hash, right?
Yes
> Should we consider invoking this with python3?
I am not sure if all the bots (including external bots) having python 3. Might be a good idea to verify that and do it in separate patch.
Comment 5 EWS 2021-01-20 15:06:07 PST
Committed r271675: <https://trac.webkit.org/changeset/271675>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417995 [details].
Comment 6 Radar WebKit Bug Importer 2021-01-20 15:07:14 PST
<rdar://problem/73422109>