Bug 220768 – Update LayoutTests/imported/w3c/web-platform-tests/shadow-dom to the latest

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Tetsuharu Ohzeki [UTC+9]]

...

[Tetsuharu Ohzeki [UTC+9]]

I'm waiting to merge https://github.com/web-platform-tests/wpt/pull/27256

[Radar WebKit Bug Importer]

<rdar://problem/73474764>

[Ryosuke Niwa]

Reviewed & merged the upstream change.

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 419397 [details]
Patch

[Tetsuharu Ohzeki [UTC+9]]

(In reply to Ryosuke Niwa from comment #3)
> Reviewed & merged the upstream change.

Thanks!

[Tetsuharu Ohzeki [UTC+9]]

Created attachment 419424 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 419424 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419424&action=review

> LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash-expected.txt:1
> +CONSOLE MESSAGE: SyntaxError: Cannot declare a const variable twice: 'root'.

Huh, we should fix this test upstream!

> LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash.html:30
> +  const root = host.attachShadow({mode:"open"});

This is clearly wrong.

[EWS]

Committed r272458: <https://trac.webkit.org/changeset/272458>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 419424 [details].

[Tetsuharu Ohzeki [UTC+9]]

(In reply to Ryosuke Niwa from comment #7)
> Comment on attachment 419424 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419424&action=review
> 
> > LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash-expected.txt:1
> > +CONSOLE MESSAGE: SyntaxError: Cannot declare a const variable twice: 'root'.
> 
> Huh, we should fix this test upstream!
> 
> > LayoutTests/imported/w3c/web-platform-tests/shadow-dom/nested-slot-remove-crash.html:30
> > +  const root = host.attachShadow({mode:"open"});
> 
> This is clearly wrong.

Thank you for your r+cq+!

I think so too and opened https://github.com/web-platform-tests/wpt/pull/27510.
But,,, I cannot see the original chromium bug and the reason. I’m not confident that this should be fixed.
(I suspect strongly this `const` is mistake)

[Amir Mark Jr]

This test is crashing after this patch was created:

imported/w3c/web-platform-tests/shadow-dom/declarative/declarative-shadow-dom-attachment.tentative.html

Link to the bug tracking this issue:

https://bugs.webkit.org/show_bug.cgi?id=221634