Bug 220760 - Remove remaining non-standard CMYKA support from canvas
Summary: Remove remaining non-standard CMYKA support from canvas
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-19 19:03 PST by Sam Weinig
Modified: 2021-01-20 05:56 PST (History)
11 users (show)

See Also:

Attachments
Patch (4.87 KB, patch)
2021-01-19 19:05 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (6.32 KB, patch)
2021-01-20 05:06 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-01-19 19:03:05 PST 
"Remove remaining non-standard CMYKA support from Canvas"
Comment 1 Sam Weinig 2021-01-19 19:05:50 PST 
Created attachment 417938 [details]
Patch
Comment 2 Darin Adler 2021-01-19 19:07:19 PST 
Comment on attachment 417938 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417938&action=review

> Source/WebCore/ChangeLog:10
> +        In r267645, most of the non-standard CMYKA taking functions on `CanvasRenderingContext2D`
> +        were removed, leaving only the `setShadow` overload left. This finishes that removal and
> +        cleans up some dead declarations that were left behind.

You’re implying but not stating here that we have some confidence no one is relying on this setShadow overload that we left by accident.
Comment 3 Wenson Hsieh 2021-01-19 19:07:34 PST 
Comment on attachment 417938 [details]
Patch

r=me (assuming EWS is green)
Comment 4 Sam Weinig 2021-01-19 19:10:39 PST 
(In reply to Darin Adler from comment #2)
> Comment on attachment 417938 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417938&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        In r267645, most of the non-standard CMYKA taking functions on `CanvasRenderingContext2D`
> > +        were removed, leaving only the `setShadow` overload left. This finishes that removal and
> > +        cleans up some dead declarations that were left behind.
> 
> You’re implying but not stating here that we have some confidence no one is
> relying on this setShadow overload that we left by accident.

I am, but I should state it more clearly. I will probably also need to rebase some tests, so I will update the ChangeLog when I do that. Thanks (glad you have the review+ back too, it was a rough couple of minutes :) ).
Comment 5 Sam Weinig 2021-01-20 05:06:34 PST 
Created attachment 417959 [details]
Patch
Comment 6 EWS 2021-01-20 05:55:18 PST 
Committed r271646: <https://trac.webkit.org/changeset/271646>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417959 [details].
Comment 7 Radar WebKit Bug Importer 2021-01-20 05:56:14 PST 
<rdar://problem/73401650>