Bug 220759 - REGRESSION (r271508) Scrolling is no longer smooth
Summary: REGRESSION (r271508) Scrolling is no longer smooth
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Scrolling (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-19 18:41 PST by Simon Fraser (smfr)
Modified: 2021-01-19 21:24 PST (History)
10 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2021-01-19 18:41 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2021-01-19 18:41:01 PST 
REGRESSION (r271508) Scrolling is no longer smooth
Comment 1 Simon Fraser (smfr) 2021-01-19 18:41:58 PST 
Created attachment 417936 [details]
Patch
Comment 2 Darin Adler 2021-01-19 19:08:15 PST 
Comment on attachment 417936 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417936&action=review

> Source/WebCore/ChangeLog:9
> +        r271508 has a logic error that resulted in no scrolling thread layer commits, which meant that
> +        scrolling on pages with a busy main thread only updated layers at main thread cadence.

Is a regression test possible?
Comment 3 Simon Fraser (smfr) 2021-01-19 21:07:23 PST 
I'd have to write a bunch of infrastructure to test this (count layer commits on the scrolling thread).
Comment 4 EWS 2021-01-19 21:23:12 PST 
Committed r271637: <https://trac.webkit.org/changeset/271637>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417936 [details].
Comment 5 Radar WebKit Bug Importer 2021-01-19 21:24:14 PST 
<rdar://problem/73388312>