Bug 220743 – REGRESSION (r271559): [BigSur] fast/forms/password-scrolled-after-caps-lock-toggled.html is consistently failing

• Status: RESOLVED
• Resolution: FIXED
• Component: Scrolling

[Ryan Haddad]

After https://trac.webkit.org/changeset/271559/webkit landed, fast/forms/password-scrolled-after-caps-lock-toggled.html is consistently failing on Big Sur bots:

--- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/fast/forms/password-scrolled-after-caps-lock-toggled-expected.txt
+++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/fast/forms/password-scrolled-after-caps-lock-toggled-actual.txt
@@ -25,7 +25,7 @@
 PASS document.getElementById('input').scrollLeft is 0
 
 After caps lock enabled:
-PASS document.getElementById('input').scrollLeft is 0
+FAIL document.getElementById('input').scrollLeft should be 0. Was 5.
 
 After caps lock disabled:
 PASS document.getElementById('input').scrollLeft is 0
@@ -39,6 +39,7 @@
 After caps lock disabled:
 PASS document.getElementById('input').scrollLeft is 0
 PASS successfullyParsed is true
+Some tests failed.
 
 TEST COMPLETE
 
https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fpassword-scrolled-after-caps-lock-toggled.html

[Radar WebKit Bug Importer]

<rdar://problem/73368910>

[Ryan Haddad]

I'll go ahead and revert this change since we have a confirmed regression point.

[Ryan Haddad]

(In reply to Ryan Haddad from comment #2)
> I'll go ahead and revert this change since we have a confirmed regression
> point.
https://trac.webkit.org/changeset/271598/webkit would also need to go, so maybe this needs a look sooner rather than later.

[Simon Fraser (smfr)]

Rollouts will cause a lot of churn with these big patches, and Nikolas will look at this soon, so I'd prefer to hold off on the rollout.

[Nikolas Zimmermann]

Regression confirmed, will look into it right now.

[Nikolas Zimmermann]

Created attachment 418029 [details]
Patch

[Nikolas Zimmermann]

While this fixes the regression on the fast/forms/password-...* text, it has side effects for two other test categories, that I'm investigating.

I'm on it - stay tuned.

[Simon Fraser (smfr)]

I'm sure it's obvious, but you just need to match the behavior from before the RenderLayer split.

[Nikolas Zimmermann]

Created attachment 418094 [details]
Patch

[EWS]

Committed r271732: <https://trac.webkit.org/changeset/271732>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418094 [details].