Object.assign should always throw if `target` is non-extensible
Created attachment 417838 [details] Patch
Comment on attachment 417838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417838&action=review r=me with comments > Source/JavaScriptCore/ChangeLog:3 > + Object.assign should always throw if `target` is non-extensible Seems like "always" is a bit too strong if we don't throw when updating a property, right? > Source/JavaScriptCore/ChangeLog:12 > + Aligns JSC with the spec [1], V8, and SpiderMonkey. Should we add a test262 test too?
<rdar://problem/73478307>
Committed r272411: <https://trac.webkit.org/changeset/272411>
(In reply to Ross Kirsling from comment #2) Thank you for review, Ross! > Seems like "always" is a bit too strong if we don't throw when updating a > property, right? Absolutely, I've renamed the bug. > Should we add a test262 test too? Extensive tests are coming in https://github.com/tc39/test262/pull/2945.