Introduce a MediaSessionGroupIdentifier
Created attachment 417819 [details] Patch
Created attachment 417820 [details] Patch
Created attachment 417822 [details] Patch
Created attachment 417830 [details] Patch
Comment on attachment 417830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417830&action=review > Source/WebCore/dom/Document.cpp:-760 > -#endif I removed that code that seems not needed given audio producers (media element, audio context) are stopped as active dom objects. Am I missing some cases?
Comment on attachment 417830 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417830&action=review > Source/WebCore/page/Page.cpp:2121 > + return identifier ? makeObjectIdentifier<MediaSessionGroupIdentifierType>(identifier->toUInt64()) : MediaSessionGroupIdentifier { }; This will be called frequently, would it be worth caching the identifier in a member variable?
Created attachment 417948 [details] Patch for landing
Created attachment 417949 [details] Patch for landing
(In reply to Eric Carlson from comment #6) > Comment on attachment 417830 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417830&action=review > > > Source/WebCore/page/Page.cpp:2121 > > + return identifier ? makeObjectIdentifier<MediaSessionGroupIdentifierType>(identifier->toUInt64()) : MediaSessionGroupIdentifier { }; > > This will be called frequently, would it be worth caching the identifier in > a member variable? Done
Committed r271643: <https://trac.webkit.org/changeset/271643> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417949 [details].
<rdar://problem/73397046>