Bug 220695 - [JSC] FTL OSR entry FlushFormat array is reversed
Summary: [JSC] FTL OSR entry FlushFormat array is reversed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-17 21:13 PST by Yusuke Suzuki
Modified: 2021-01-17 23:16 PST (History)
7 users (show)

See Also:

Attachments
Patch (3.71 KB, patch)
2021-01-17 21:14 PST, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2021-01-17 21:13:33 PST 
[JSC] FTL OSR entry FlushFormat array is reversed
Comment 1 Yusuke Suzuki 2021-01-17 21:14:54 PST 
Created attachment 417791 [details]
Patch
Comment 2 Yusuke Suzuki 2021-01-17 21:14:57 PST 
<rdar://problem/72930932>
Comment 3 Mark Lam 2021-01-17 22:19:18 PST 
Comment on attachment 417791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417791&action=review

r=me with suggested comment change.

> Source/JavaScriptCore/ChangeLog:9
> +        After r268783, FTL OSR entry FlushFormat array is reversed wrongly.

I think you meant to say "FlushFormat array is erroneously sorted in reversed order".
Comment 4 Yusuke Suzuki 2021-01-17 23:09:34 PST 
Comment on attachment 417791 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417791&action=review

>> Source/JavaScriptCore/ChangeLog:9
>> +        After r268783, FTL OSR entry FlushFormat array is reversed wrongly.
> 
> I think you meant to say "FlushFormat array is erroneously sorted in reversed order".

Fixed.
Comment 5 Yusuke Suzuki 2021-01-17 23:16:11 PST 
Committed r271571: <https://trac.webkit.org/changeset/271571>