Bug 220678 - Bugzilla patch upload no longer displays the agreement for some users
Summary: Bugzilla patch upload no longer displays the agreement for some users
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: lingho@apple.com
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-15 17:39 PST by lingho@apple.com
Modified: 2021-01-15 19:47 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2021-01-15 18:46 PST, lingho@apple.com 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description lingho@apple.com 2021-01-15 17:39:44 PST 
When "Show Advanced Fields" is not selected, during the process of uploading an attachement, if the Content Type: "patch" checkbox is selected, the WebKit Contribution Terms legal notes are not displayed.
Comment 1 lingho@apple.com 2021-01-15 17:41:18 PST 
<rdar://problem/72243742> Bugzilla patch upload no longer displays the agreement for some users
Comment 2 lingho@apple.com 2021-01-15 18:46:05 PST 
Created attachment 417755 [details]
Patch
Comment 3 lingho@apple.com 2021-01-15 18:51:44 PST 
Another possibility to fix this is to add !important to style="display: none;" but I think based on the comment mentioned in https://trac.webkit.org/r174772 whether Show/Hide Advanced Fields clicked, I think we should remove class="expert_fields" .
Comment 4 EWS 2021-01-15 19:47:57 PST 
Committed r271552: <https://trac.webkit.org/changeset/271552>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417755 [details].