Bug 220672 - Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
Summary: Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-15 14:06 PST by Andres Gonzalez
Modified: 2021-01-18 16:03 PST (History)
9 users (show)

See Also:

Attachments
Patch (2.16 KB, patch)
2021-01-15 14:23 PST, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2021-01-15 14:06:26 PST 
Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
Comment 1 Andres Gonzalez 2021-01-15 14:12:21 PST 
<rdar://problem/73045466>
Comment 2 Andres Gonzalez 2021-01-15 14:23:12 PST 
Created attachment 417739 [details]
Patch
Comment 3 Darin Adler 2021-01-15 15:11:05 PST 
Comment on attachment 417739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review

> Source/WebCore/ChangeLog:10
> +        The call to AccessibilityObject::setFocused to set the focus to the
> +        scroll view needs to happen before the check for canSetFocusAttribute.

Normally we require a regression test when we fix a bug. Is there a way to fix this?
Comment 4 Darin Adler 2021-01-15 15:26:03 PST 
Comment on attachment 417739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review

>> Source/WebCore/ChangeLog:10
>> +        scroll view needs to happen before the check for canSetFocusAttribute.
> 
> Normally we require a regression test when we fix a bug. Is there a way to fix this?

I meant to say, "Is there way to make a regression test for this?"
Comment 5 Andres Gonzalez 2021-01-18 14:21:02 PST 
(In reply to Darin Adler from comment #4)
> Comment on attachment 417739 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417739&action=review
> 
> >> Source/WebCore/ChangeLog:10
> >> +        scroll view needs to happen before the check for canSetFocusAttribute.
> > 
> > Normally we require a regression test when we fix a bug. Is there a way to fix this?
> 
> I meant to say, "Is there way to make a regression test for this?"

So far I haven't found any example of a LayoutTest that mimics switching focus to a web view from another view. I don't know if it is possible in the context of LayoutTests.
Comment 6 EWS 2021-01-18 16:03:52 PST 
Committed r271589: <https://trac.webkit.org/changeset/271589>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417739 [details].