WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
22067
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()
https://bugs.webkit.org/show_bug.cgi?id=22067
Summary
[GTK] Sun Java plugin segfaults at PluginPackage::createPackage()
Michael Monreal
Reported
2008-11-04 13:46:21 PST
I regularly do WebKit/GTK builds. For some time now I see segfaults while loading most webpages. See the attached gdb log (example visiting osnews.com).
Attachments
GDB output
(4.31 KB, text/plain)
2008-11-04 13:48 PST
,
Michael Monreal
no flags
Details
config.log
(43.75 KB, application/octet-stream)
2008-11-05 10:30 PST
,
Michael Monreal
no flags
Details
Fix Java plugin segfaults
(3.46 KB, patch)
2008-11-06 04:15 PST
,
Alp Toker
zwarich
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Monreal
Comment 1
2008-11-04 13:48:34 PST
Created
attachment 24893
[details]
GDB output
Alp Toker
Comment 2
2008-11-05 08:27:22 PST
(In reply to
comment #0
)
> I regularly do WebKit/GTK builds. For some time now I see segfaults while > loading most webpages. See the attached gdb log (example visiting osnews.com). >
Hi! Can you try one of the patches in
bug #22033
(
attachment 24884
[details]
or 24885) and report back success/failure?
Alp Toker
Comment 3
2008-11-05 08:28:07 PST
The output of your config.log and your actual CPU architecture will help too.
Michael Monreal
Comment 4
2008-11-05 10:30:48 PST
Created
attachment 24911
[details]
config.log Here's my config.log I'll try the patches now, but the bug says they are meant to fix crashes on google... which actually seems to be one of the few pages that fully load without crashing for me.
Michael Monreal
Comment 5
2008-11-05 11:02:32 PST
Neither of the patches fixes the problem.
Alp Toker
Comment 6
2008-11-05 11:35:38 PST
(In reply to
comment #5
)
> Neither of the patches fixes the problem. >
Thanks for checking. Which SVN revision are you testing with and do you have a known-good revision number where the problem didn't show up? The backtrace suggests this crash may be related to the plugin code. Can you get a list of the plugins you have installed (both in ~/.mozilla and the system)? Especially if it's trying to load Java or the gjs Java plugin or swfdec which I think might already have proposed fixes.. If you have time to narrow down the plugin causing the issue by moving them out of the way and moving them back one by one, that could help too. I'm going to try pinging some people who might have more ideas on this.
Michael Monreal
Comment 7
2008-11-05 13:04:40 PST
(In reply to
comment #6
)
> The backtrace suggests this crash may be related to the plugin code
You are totally right! The segfault is caused by the new java plugin (libnpjp2.so). After removing this one, everything seems to work quite stable. Actually, I have yet to see any crash... great! Even better if this is already known and has proposed patches. Feel free to close or mark as dupe.
Alp Toker
Comment 8
2008-11-05 15:23:55 PST
Let's keep this open until we either blacklist the plugin or fix the crash.
Alp Toker
Comment 9
2008-11-05 18:51:35 PST
(In reply to
comment #7
)
> (In reply to
comment #6
) > > The backtrace suggests this crash may be related to the plugin code > > You are totally right! The segfault is caused by the new java plugin > (libnpjp2.so). After removing this one, everything seems to work quite stable. > Actually, I have yet to see any crash... great!
Found the cause of the crash. It's due to the lack of null checking following g_module_symbol() calls. I've been trying to get the plugin working but I don't know what to make of it. libnpjp2.so is unusual in that it: 1) Doesn't provide the expected NP_GetValue function symbol 2) Doesn't explicitly link to libnspr.so which it seems to use (working around this with LD_PRELOAD=/usr/lib/libnspr4.so for testing) I'm beginning to suspect the new Java plugin is tied more closely to Mozilla internals than its predecessors and other plugins in which case the best I'll be able to do is fix the crash. On the plus side, the crash fixes I'm cooking up will make the plugin code more robust in general.
Michael Monreal
Comment 10
2008-11-06 00:30:16 PST
Well this plugin is not the default ATM I think. I was told to give it a try because the old one crashed on tribaltrouble2.com.
Alp Toker
Comment 11
2008-11-06 04:15:25 PST
Created
attachment 24939
[details]
Fix Java plugin segfaults
Cameron Zwarich (cpst)
Comment 12
2008-11-06 10:15:08 PST
Comment on
attachment 24939
[details]
Fix Java plugin segfaults r=me
Alp Toker
Comment 13
2008-11-06 13:18:22 PST
Landed in
r38184
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug