Bug 220654 – [GStreamer][Playbin3] Support for CEA-608 closed captioned media

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Philippe Normand]

.

[Philippe Normand]

Created attachment 418546 [details]
Patch

[Xabier Rodríguez Calvar]

Comment on attachment 418546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418546&action=review

> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93
> +            WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs");

I would GST_ERROR on this as well, but up to you.

[Philippe Normand]

(In reply to Xabier Rodríguez Calvar from comment #2)
> Comment on attachment 418546 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418546&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:93
> > +            WTFLogAlways("GStreamer closedcaption plugins are missing. Please install gst-plugins-bad and gst-plugins-rs");
> 
> I would GST_ERROR on this as well, but up to you.

Well the whole pipeline would fail in this case anyway due to the unlinked pad. I'm not sure another GST_ERROR is needed :)

[Philippe Normand]

Committed r272055: <https://trac.webkit.org/changeset/272055>

[Radar WebKit Bug Importer]

<rdar://problem/73747252>

[Robert Jenner]

It appears that this revision has broken then test in macOS and iOS:
media/track/track-in-band-style.html

Bug created:
https://bugs.webkit.org/show_bug.cgi?id=221835

[Robert Jenner]

Jer has informed us, that this is a rebaseline. We are going to rebaseline with:

https://bugs.webkit.org/show_bug.cgi?id=221835