Bug 220643 - Web Inspector: Sources: editing a breakpoint action to cause the CodeMirror to wrap doesn't update the `WI.Popover` size
Summary: Web Inspector: Sources: editing a breakpoint action to cause the CodeMirror t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-01-14 17:14 PST by Devin Rousso
Modified: 2022-05-27 16:55 PDT (History)
4 users (show)

See Also:


Attachments
[Image] screenshot of issue (79.25 KB, image/png)
2021-01-14 17:14 PST, Devin Rousso
no flags Details
[Video] Bug (4.78 MB, video/quicktime)
2021-01-21 14:40 PST, Nikita Vasilyev
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-01-14 17:14:35 PST
Created attachment 417670 [details]
[Image] screenshot of issue

# STEPS TO REPRODUCE
1. inspect any page
2. create a breakpoint
3. add an Evaluate JavaScript action
4. type in the CodeMirror input until the code wraps

# EXPECTED
the `WI.Popover` would adjust its size to accommodate the new space taken up by the wrapped code

# ACTUAL
the `WI.Popover` doesn't adjust

# NOTES
this is not an issue when adding an actual new line
Comment 1 Radar WebKit Bug Importer 2021-01-14 17:14:46 PST
<rdar://problem/73225206>
Comment 2 Nikita Vasilyev 2021-01-21 14:40:41 PST
Created attachment 418088 [details]
[Video] Bug

I bisected up to 12 months back and I couldn't find a build that resizes the popover on line wrap. Video of a bug attached.
Comment 3 Devin Rousso 2022-05-27 12:50:07 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1112
Comment 4 EWS 2022-05-27 16:55:45 PDT
Committed r294968 (251072@main): <https://commits.webkit.org/251072@main>

Reviewed commits have been landed. Closing PR #1112 and removing active labels.