Polish the new WebAuthn UI.
<rdar://problem/73185470>
Created attachment 417601 [details] Patch
Created attachment 417643 [details] Patch
Created attachment 417647 [details] Patch
Created attachment 417751 [details] Patch
Comment on attachment 417751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417751&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:-68 > - ASSERT(!RunLoop::isMain()); Why is it okay to remove this assertion? Should we be asserting that we are on the main runloop when UI is being presented?
Comment on attachment 417751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417751&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:-68 >> - ASSERT(!RunLoop::isMain()); > > Why is it okay to remove this assertion? Should we be asserting that we are on the main runloop when UI is being presented? Just figured that the UI SPI could bail out early on the main thread and in Cocoa API there isn't any guarantees which thread the callback is going to be executed. So we shouldn't assume any.
Committed r271613: <https://trac.webkit.org/changeset/271613> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417751 [details].