Bug 220617 - [WebAuthn] Polish the new WebAuthn UI
Summary: [WebAuthn] Polish the new WebAuthn UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks: 181943
  Show dependency treegraph
 
Reported: 2021-01-14 00:02 PST by Jiewen Tan
Modified: 2021-01-19 13:28 PST (History)
3 users (show)

See Also:


Attachments
Patch (15.04 KB, patch)
2021-01-14 00:14 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (15.05 KB, patch)
2021-01-14 12:30 PST, Jiewen Tan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.08 KB, patch)
2021-01-14 13:06 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff
Patch (15.49 KB, patch)
2021-01-15 17:28 PST, Jiewen Tan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-01-14 00:02:11 PST
Polish the new WebAuthn UI.
Comment 1 Radar WebKit Bug Importer 2021-01-14 00:02:41 PST
<rdar://problem/73185470>
Comment 2 Jiewen Tan 2021-01-14 00:14:14 PST
Created attachment 417601 [details]
Patch
Comment 3 Jiewen Tan 2021-01-14 12:30:14 PST
Created attachment 417643 [details]
Patch
Comment 4 Jiewen Tan 2021-01-14 13:06:27 PST
Created attachment 417647 [details]
Patch
Comment 5 Jiewen Tan 2021-01-15 17:28:03 PST
Created attachment 417751 [details]
Patch
Comment 6 Brent Fulgham 2021-01-19 09:26:49 PST
Comment on attachment 417751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417751&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:-68
> -        ASSERT(!RunLoop::isMain());

Why is it okay to remove this assertion? Should we be asserting that we are on the main runloop when UI is being presented?
Comment 7 Jiewen Tan 2021-01-19 10:39:53 PST
Comment on attachment 417751 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417751&action=review

Thanks Brent for r+ this patch.

>> Source/WebKit/UIProcess/WebAuthentication/Cocoa/AuthenticatorPresenterCoordinator.mm:-68
>> -        ASSERT(!RunLoop::isMain());
> 
> Why is it okay to remove this assertion? Should we be asserting that we are on the main runloop when UI is being presented?

Just figured that the UI SPI could bail out early on the main thread and in Cocoa API there isn't any guarantees which thread the callback is going to be executed. So we shouldn't  assume any.
Comment 8 EWS 2021-01-19 13:28:01 PST
Committed r271613: <https://trac.webkit.org/changeset/271613>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417751 [details].