Bug 220608 – REGRESSION(r266695) Range control with custom track width sized incorrectly

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://problem/73120825>

[zalan]

Created attachment 417577 [details]
test reduction

[Simon Fraser (smfr)]

Do we need to change the styling on range inputs to handle this case?

[Sergio Villar Senin]

(In reply to Simon Fraser (smfr) from comment #2)
> Do we need to change the styling on range inputs to handle this case?

I think so, the issues that appear with "min-size:auto" changes are normally fixed by setting 0 as the min-size (which was the default before and thus a lot of code relies on that).

Zalan, will this patch provide the expected results:

diff --git a/Source/WebCore/css/html.css b/Source/WebCore/css/html.css
index c2ffebcf0716..011939f1e9ca 100644
--- a/Source/WebCore/css/html.css
+++ b/Source/WebCore/css/html.css
@@ -834,6 +834,7 @@ input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-medi
     box-sizing: border-box;
     display: flex;
     align-contents: center;
+    min-width: 0;
 }
 
 input[type="range"]::-webkit-slider-runnable-track {

[zalan]

It does. It's pretty embarrassing that we've got to add such hacks to make things work while the proper solution is as simple as this

diff --git a/Source/WebCore/rendering/style/RenderStyle.h b/Source/WebCore/rendering/style/RenderStyle.h
index 804454d3e241..50ed6877bf75 100644
--- a/Source/WebCore/rendering/style/RenderStyle.h
+++ b/Source/WebCore/rendering/style/RenderStyle.h
@@ -1551,7 +1551,7 @@ public:
     static float initialLetterSpacing() { return 0; }
     static Length initialWordSpacing() { return Length(Fixed); }
     static Length initialSize() { return Length(); }
-    static Length initialMinSize() { return Length(); }
+    static Length initialMinSize() { return Length(Fixed); }
     static Length initialMaxSize() { return Length(Undefined); }
     static Length initialOffset() { return Length(); }
     static Length initialRadius() { return Length(); }

[Sergio Villar Senin]

(In reply to zalan from comment #4)
> It does. It's pretty embarrassing that we've got to add such hacks to make
> things work while the proper solution is as simple as this
> 
> diff --git a/Source/WebCore/rendering/style/RenderStyle.h
> b/Source/WebCore/rendering/style/RenderStyle.h
> index 804454d3e241..50ed6877bf75 100644
> --- a/Source/WebCore/rendering/style/RenderStyle.h
> +++ b/Source/WebCore/rendering/style/RenderStyle.h
> @@ -1551,7 +1551,7 @@ public:
>      static float initialLetterSpacing() { return 0; }
>      static Length initialWordSpacing() { return Length(Fixed); }
>      static Length initialSize() { return Length(); }
> -    static Length initialMinSize() { return Length(); }
> +    static Length initialMinSize() { return Length(Fixed); }
>      static Length initialMaxSize() { return Length(Undefined); }
>      static Length initialOffset() { return Length(); }
>      static Length initialRadius() { return Length(); }

Well but we cannot do this right? Unless I'm missing something the initial value for min-size properties must be auto.

[zalan]

(In reply to Sergio Villar Senin from comment #5)
> (In reply to zalan from comment #4)
> > It does. It's pretty embarrassing that we've got to add such hacks to make
> > things work while the proper solution is as simple as this
> > 
> > diff --git a/Source/WebCore/rendering/style/RenderStyle.h
> > b/Source/WebCore/rendering/style/RenderStyle.h
> > index 804454d3e241..50ed6877bf75 100644
> > --- a/Source/WebCore/rendering/style/RenderStyle.h
> > +++ b/Source/WebCore/rendering/style/RenderStyle.h
> > @@ -1551,7 +1551,7 @@ public:
> >      static float initialLetterSpacing() { return 0; }
> >      static Length initialWordSpacing() { return Length(Fixed); }
> >      static Length initialSize() { return Length(); }
> > -    static Length initialMinSize() { return Length(); }
> > +    static Length initialMinSize() { return Length(Fixed); }
> >      static Length initialMaxSize() { return Length(Undefined); }
> >      static Length initialOffset() { return Length(); }
> >      static Length initialRadius() { return Length(); }
> 
> Well but we cannot do this right? Unless I'm missing something the initial
> value for min-size properties must be auto.

Yeah, I didn't upload this as a patch, did I (j/k) :)

[Sergio Villar Senin]

Created attachment 417808 [details]
Patch

[zalan]

Comment on attachment 417808 [details]
Patch

It looks ready to be landed. Let me just cq+-it. Hope you don't mind it.

[EWS]

Committed r271618: <https://trac.webkit.org/changeset/271618>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 417808 [details].